Skip to content

Auxiliary autodiscovery#71911

Merged
vdimir merged 5 commits intoClickHouse:masterfrom
ianton-ru:auxiliary_autodicovery
Nov 20, 2024
Merged

Auxiliary autodiscovery#71911
vdimir merged 5 commits intoClickHouse:masterfrom
ianton-ru:auxiliary_autodicovery

Conversation

@ianton-ru
Copy link
Copy Markdown
Contributor

@ianton-ru ianton-ru commented Nov 14, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use auxiliary keepers for cluster autodiscovery

Documentation entry for user-facing changes

Cluster autodicovery feature did not work with auxiliary keepers:

2024.11.14 10:41:23.511057 [ 658 ] {} <Error> ZooKeeperClient: Code: 999. Coordination::Exception: Path must begin with /, got path 'zookeeper2:/clickhouse/discovery/test_auto_cluster/shards'. (KEEPER_EXCEPTION), Stack trace (when copying this message, always include the lines below):

0. ./contrib/llvm-project/libcxx/include/exception:141: Poco::Exception::Exception(String const&, int) @ 0x000000001439dbf2
1. /home/iantonspb/ch-build/./src/Common/Exception.cpp:109: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000b4d19b9
2. DB::Exception::Exception(PreformattedMessage&&, int) @ 0x000000000691ef0c
3. DB::Exception::Exception<String&>(int, FormatStringHelperImpl<std::type_identity<String&>::type>, String&) @ 0x000000000693876b
4. ./src/Common/ZooKeeper/IKeeper.h:512: Coordination::Exception::Exception<String&>(Coordination::Error, FormatStringHelperImpl<std::type_identity<String&>::type>, String&) @ 0x00000000111bb2ab
5. /home/iantonspb/ch-build/./src/Common/ZooKeeper/IKeeper.cpp:96: Coordination::addRootPath(String&, String const&) @ 0x000000001243eeeb
6. /home/iantonspb/ch-build/./src/Common/ZooKeeper/ZooKeeperImpl.cpp:758: Coordination::ZooKeeper::sendThread() @ 0x000000001249c1ac
7. /home/iantonspb/ch-build/./src/Common/ZooKeeper/ZooKeeperImpl.cpp:406: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true, true>::ThreadFromGlobalPoolImpl<Coordination::ZooKeeper::ZooKeeper(std::vector<zkutil::ShuffleHost, std::allocator<zkutil::ShuffleHost>> const&, zkutil::ZooKeeperArgs const&, std::shared_ptr<DB::ZooKeeperLog>)::$_0>(Coordination::ZooKeeper::ZooKeeper(std::vector<zkutil::ShuffleHost, std::allocator<zkutil::ShuffleHost>> const&, zkutil::ZooKeeperArgs const&, std::shared_ptr<DB::ZooKeeperLog>)::$_0&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x00000000124a3047
8. ./contrib/llvm-project/libcxx/include/__functional/function.h:848: ? @ 0x000000000b59dbc3
9. ./contrib/llvm-project/libcxx/include/__functional/invoke.h:359: ? @ 0x000000000b5a2e9b
10. ? @ 0x00007f4fada05ac3
11. ? @ 0x00007f4fada97850
 (version 24.11.1.1)

Now it works.

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@ianton-ru ianton-ru changed the title Auxiliary autodicovery Auxiliary autodiscovery Nov 14, 2024
filimonov
filimonov reviewed Nov 18, 2024
View reviewed changes
tests/integration/test_cluster_discovery/config/config_observer.xml
<remote_servers>
<test_auto_cluster>
<discovery>
<path>/clickhouse/discovery/test_auto_cluster</path>
Copy link
Copy Markdown
Contributor

@filimonov filimonov Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed?

Copy link
Copy Markdown
Contributor Author

@ianton-ru ianton-ru Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to separate file config_discovery_path.xml/config_discovery_path_auxiliary_keeper.xml. There are two different paths for different tests (/clickhouse/discovery/test_auto_cluster for old one and zookeeper2:/clickhouse/discovery/test_auto_cluster for new one) , and I reused configs except discovery paths in both tests.

@vdimir vdimir added the can be tested Allows running workflows for external contributors label Nov 18, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Nov 18, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Nov 18, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 9917dc6 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@ianton-ru ianton-ru marked this pull request as ready for review November 19, 2024 10:09
@vdimir vdimir self-assigned this Nov 20, 2024
@vdimir vdimir added this pull request to the merge queue Nov 20, 2024
Merged via the queue into ClickHouse:master with commit 59fe7e1 Nov 20, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 20, 2024
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Nov 22, 2024
@vdimir @Enmk
Merge pull request ClickHouse#71911 from ianton-ru/auxiliary_autodico…
5a20e8c 
…very

Auxiliary autodiscovery
@Enmk Enmk mentioned this pull request Nov 22, 2024
Merged
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Nov 22, 2024
@vdimir @Enmk
Merge pull request ClickHouse#71911 from ianton-ru/auxiliary_autodico…
3d198f5 
…very

Auxiliary autodiscovery
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Nov 22, 2024
@vdimir @Enmk
Merge pull request ClickHouse#71911 from ianton-ru/auxiliary_autodico…
6004f30 
…very

Auxiliary autodiscovery
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Nov 25, 2024
@vdimir @Enmk
Merge pull request ClickHouse#71911 from ianton-ru/auxiliary_autodico…
7a30901 
…very

Auxiliary autodiscovery
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Nov 25, 2024
@vdimir @Enmk
Merge pull request ClickHouse#71911 from ianton-ru/auxiliary_autodico…
0984d0f 
…very

Auxiliary autodiscovery
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Dec 3, 2024
@Enmk
Merge pull request #531 from Altinity/24.8_backport_71911_auxiliary_z…
a3a887e 
…ookeeper_autodiscovery

24.8 Backport of ClickHouse#71911 - Auxiliary zookeper autodiscovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

+1 more reviewer

@filimonov filimonov filimonov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vdimir vdimir

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ianton-ru @robot-ch-test-poll @filimonov @vdimir @robot-ch-test-poll3