Skip to content

Corrections after reworking backup/restore synchronization#71715

Merged
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom
vitlibar:correction-after-reworking-backup-sync
Nov 13, 2024
Merged

Corrections after reworking backup/restore synchronization#71715
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom
vitlibar:correction-after-reworking-backup-sync

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Nov 10, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Follow-up to #70027

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 10, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Nov 10, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 19bcc55 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vitlibar vitlibar force-pushed the correction-after-reworking-backup-sync branch 5 times, most recently from b48c1cd to afcb7d2 Compare November 11, 2024 08:21
@vitlibar vitlibar force-pushed the correction-after-reworking-backup-sync branch from afcb7d2 to 19bcc55 Compare November 11, 2024 10:12
@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Nov 11, 2024

CI failures are unrelated:

@vitlibar
Copy link
Copy Markdown
Member Author

vitlibar commented Nov 11, 2024 •
edited
Loading

After #70027 a bunch of tests were flaky showing that some cases were not taken into account in #70027. This PR is to fix those tests and the issues found by those tests.

vitlibar
vitlibar commented Nov 11, 2024
View reviewed changes
vitlibar
vitlibar commented Nov 11, 2024
View reviewed changes
@nikitamikhaylov nikitamikhaylov self-assigned this Nov 13, 2024
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Nov 13, 2024
Merged via the queue into ClickHouse:master with commit 191fe99 Nov 13, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 13, 2024
@vitlibar vitlibar mentioned this pull request Nov 14, 2024
Merged
@vitlibar vitlibar deleted the correction-after-reworking-backup-sync branch November 14, 2024 11:47
@vitlibar vitlibar mentioned this pull request Nov 17, 2024
Merged
@nikitamikhaylov nikitamikhaylov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 10, 2024
This was referenced Dec 10, 2024
Closed
Closed
Closed
Closed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label Dec 10, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vitlibar @robot-ch-test-poll2 @nikitamikhaylov @robot-ch-test-poll @robot-clickhouse-ci-1 @robot-clickhouse-ci-2