Skip to content

Fix error Invalid number of rows in Chunk with Variant column#71388

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fix-variant-permute
Nov 7, 2024
Merged

Fix error Invalid number of rows in Chunk with Variant column#71388
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fix-variant-permute

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Nov 1, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix error Invalid number of rows in Chunk with Variant column.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 1, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label Nov 1, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Nov 1, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 432ca2c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CurtizJ CurtizJ self-assigned this Nov 4, 2024
@Avogar Avogar force-pushed the fix-variant-permute branch from 6caf004 to 2cc2f31 Compare November 6, 2024 15:15
@Avogar Avogar added this pull request to the merge queue Nov 7, 2024
@Avogar Avogar mentioned this pull request Nov 7, 2024
Merged
21 tasks
Merged via the queue into ClickHouse:master with commit 095f7ab Nov 7, 2024
@Avogar Avogar deleted the fix-variant-permute branch November 7, 2024 18:02
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Nov 7, 2024
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll4
Merge pull request #71599 from ClickHouse/cherrypick/24.3/095f7ab591a…
2f6256b 
…a023d87f8f281f6d0226d1d447476

Cherry pick #71388 to 24.3: Fix error Invalid number of rows in Chunk with Variant column
robot-clickhouse added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse
Backport #71388 to 24.3: Fix error Invalid number of rows in Chunk wi…
7a7a6e1 
…th Variant column
This was referenced Nov 7, 2024
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll4
Merge pull request #71601 from ClickHouse/cherrypick/24.7/095f7ab591a…
01f2ffc 
…a023d87f8f281f6d0226d1d447476

Cherry pick #71388 to 24.7: Fix error Invalid number of rows in Chunk with Variant column
robot-clickhouse added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse
Backport #71388 to 24.7: Fix error Invalid number of rows in Chunk wi…
c17543a 
…th Variant column
This was referenced Nov 7, 2024
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll4
Merge pull request #71603 from ClickHouse/cherrypick/24.8/095f7ab591a…
71506af 
…a023d87f8f281f6d0226d1d447476

Cherry pick #71388 to 24.8: Fix error Invalid number of rows in Chunk with Variant column
robot-clickhouse added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse
Backport #71388 to 24.8: Fix error Invalid number of rows in Chunk wi…
7981bfa 
…th Variant column
This was referenced Nov 7, 2024
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll4
Merge pull request #71605 from ClickHouse/cherrypick/24.9/095f7ab591a…
6ad5ccb 
…a023d87f8f281f6d0226d1d447476

Cherry pick #71388 to 24.9: Fix error Invalid number of rows in Chunk with Variant column
robot-clickhouse added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse
Backport #71388 to 24.9: Fix error Invalid number of rows in Chunk wi…
0131d17 
…th Variant column
This was referenced Nov 7, 2024
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll4
Merge pull request #71607 from ClickHouse/cherrypick/24.10/095f7ab591…
fcdf0b6 
…aa023d87f8f281f6d0226d1d447476

Cherry pick #71388 to 24.10: Fix error Invalid number of rows in Chunk with Variant column
robot-clickhouse added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse
Backport #71388 to 24.10: Fix error Invalid number of rows in Chunk w…
e8d73d0 
…ith Variant column
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Nov 7, 2024
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 7, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Nov 7, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 7, 2024
robot-ch-test-poll1 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll1
Merge pull request #71602 from ClickHouse/backport/24.7/71388
7ef4ec9 
Backport #71388 to 24.7: Fix error Invalid number of rows in Chunk with Variant column
robot-ch-test-poll2 added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll2
Merge pull request #71608 from ClickHouse/backport/24.10/71388
ae1a82c 
Backport #71388 to 24.10: Fix error Invalid number of rows in Chunk with Variant column
robot-ch-test-poll added a commit that referenced this pull request Nov 7, 2024
@robot-ch-test-poll
Merge pull request #71604 from ClickHouse/backport/24.8/71388
77fb0df 
Backport #71388 to 24.8: Fix error Invalid number of rows in Chunk with Variant column
robot-clickhouse-ci-2 added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse-ci-2
Merge pull request #71606 from ClickHouse/backport/24.9/71388
3531c1a 
Backport #71388 to 24.9: Fix error Invalid number of rows in Chunk with Variant column
Avogar added a commit that referenced this pull request Nov 11, 2024
@Avogar
Merge pull request #71600 from ClickHouse/backport/24.3/71388
fbdc7a7 
Backport #71388 to 24.3: Fix error Invalid number of rows in Chunk with Variant column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Avogar @robot-ch-test-poll1 @CurtizJ @robot-ch-test-poll4 @robot-ch-test-poll3 @robot-clickhouse-ci-1 @robot-clickhouse-ci-2