Skip to content

Read AWS EKS token from file#71269

Merged
thevar1able merged 2 commits intomasterfrom
ecs-token-from-file
Oct 31, 2024
Merged

Read AWS EKS token from file#71269
thevar1able merged 2 commits intomasterfrom
ecs-token-from-file

Conversation

@thevar1able
Copy link
Copy Markdown
Member

@thevar1able thevar1able commented Oct 30, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE instead of AWS_CONTAINER_AUTHORIZATION_TOKEN if former is available. Fixes #71074

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label Oct 30, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Oct 30, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 12e36c3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@evillique evillique self-assigned this Oct 30, 2024
@thevar1able thevar1able changed the title Read ECS token from file Read AWS EKS token from file Oct 30, 2024
nikitamikhaylov
nikitamikhaylov approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov left a comment •
edited by thevar1able
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the same logic for AWS_WEB_IDENTITY_TOKEN_FILE.

@nikitamikhaylov nikitamikhaylov self-assigned this Oct 30, 2024
@thevar1able
Copy link
Copy Markdown
Member Author

thevar1able commented Oct 31, 2024

test_table_function_mongodb/test.py Error response from daemon: No such image: mongo:6.0, unrelated
01167_isolation_hermitage #71307

@thevar1able thevar1able added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit dff28b7 Oct 31, 2024
@thevar1able thevar1able deleted the ecs-token-from-file branch October 31, 2024 14:34
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 31, 2024
@yokofly yokofly mentioned this pull request Oct 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

@evillique evillique

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWS Credentials should support AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE.

6 participants

@thevar1able @robot-clickhouse @alexey-milovidov @nikitamikhaylov @evillique @robot-ch-test-poll2