Wait pool in ParallelFormattingOutputFormat::finalizeImpl#71135
Wait pool in ParallelFormattingOutputFormat::finalizeImpl#71135
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
|
This is an automated comment for commit efd5830 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
|
| formatter->finalizeImpl(); | ||
|
|
||
| formatter->finalizeBuffers(); | ||
| finishAndWait(); |
There was a problem hiding this comment.
Maybe it's better to call pool.wait() because finishAndWait() does emergency_stop = true;?
There was a problem hiding this comment.
Maybe we need to set emergency_stop to let thread to finish (so, it's not emergence, but just stop). Let's check how it works without setting this flag from finalizeImpl
| void ParallelFormattingOutputFormat::finishAndWait(bool emergency_stop_) noexcept | ||
| { | ||
| emergency_stop = true; | ||
| emergency_stop = emergency_stop_; |
There was a problem hiding this comment.
What if emergency_stop is already set to true, but you set it to false? Let's do something like:
bool expected = false;
emergency_stop. compare_exchange_strong(expected, emergency_stop_);
…g2' into vdimir/fix-race-client-formatting2
|
Without setting |
|
Closed in favor to #71304 |
Pull request was closed
4 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
close #68791