Skip to content

Move remaining settings objects to pImpl and start simplification#71019

Merged
Algunenano merged 10 commits intoClickHouse:masterfrom
Algunenano:settings6
Oct 25, 2024
Merged

Move remaining settings objects to pImpl and start simplification#71019
Algunenano merged 10 commits intoClickHouse:masterfrom
Algunenano:settings6

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Oct 24, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Move remaining settings objects to pImpl and start simplification

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Algunenano Algunenano self-assigned this Oct 24, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 24, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Oct 24, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 7b9ee84 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Oct 25, 2024

  • AST fuzzer (asan) : Unrelated. Diff with master due to new Keeper settings.
  • Integration tests (tsan) [1/6] : test_postgresql_replica_database_engine_1/test.py::test_abrupt_connection_loss_while_heavy_replication. Unrelated. It failed at pausing a docker container.
  • 02798_explain_settings_not_applied_bug. It also seems unrelated Seems like the test is missing some setting blockers, as in this case it read 1 part but decided to use 16 threads instead of only 1.

@Algunenano Algunenano added this pull request to the merge queue Oct 25, 2024
Merged via the queue into ClickHouse:master with commit 9006eec Oct 25, 2024
@Algunenano Algunenano deleted the settings6 branch October 25, 2024 21:26
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 25, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 26, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#71019
7c86ba9
baibaichen added a commit to apache/gluten that referenced this pull request Oct 26, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241026) (#7689)
f5d42f1 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241026)

* Fix Build due to ClickHouse/ClickHouse#71019

* fix gtest build due to #7506

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
yikf pushed a commit to yikf/incubator-gluten that referenced this pull request Oct 28, 2024
@kyligence-git @baibaichen @yikf
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241026) (apache#7689
509a1a0 
)

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241026)

* Fix Build due to ClickHouse/ClickHouse#71019

* fix gtest build due to apache#7506

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Algunenano @robot-clickhouse-ci-1 @robot-ch-test-poll1