Merged
Conversation
alesapin
reviewed
Sep 25, 2019
dbms/src/Common/ProfileEvents.cpp
Outdated
| M(SelectedRanges, "Number of (non-adjacent) ranges in all data parts selected to read from a MergeTree table.") \ | ||
| M(SelectedMarks, "Number of marks (index granules) selected to read from a MergeTree table.") \ | ||
| \ | ||
| M(CountOfMerges, "") \ |
Member
There was a problem hiding this comment.
We don't have Count in the names of other metrics because counting is assumed.
Member
There was a problem hiding this comment.
Let it be named Merge.
Member
|
Need to add a test that the value of this ProfileEvent is greater than zero after merge. |
Member
|
You should fill the description for changelog. |
Add metric description. Add test.
Contributor
|
I want to add elapsed time for each stream like **BlockInputStream to get more detailed performance result? Is there any example on it? Thanks. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
New ProfileEvent
Mergeadded. It counts the number of launched background merges.