One build has failed.

@amosbird Can you explain in details what is this fix about and why the issue can't be resolved with typical CMake dependencies and interfaces? Overriding default macro looks very hacky, generally it may lead to new problems, when someone decides to do any refactoring months later.

@abyss7 When doing shared builds, TUs which try to override std symbols (such as malloc or operator new) should be statically linked into the final executable and only be linked once. It includes all unit testing executables. I cannot find easy way of collecting executables in one place other than overriding default macro.

@abyss7 When doing shared builds, TUs which try to override std symbols (such as malloc or operator new) should be directly linked into the final executable and only be linked once. It includes all unit testing executables. I cannot find easy way of collecting executables in one place other than overriding default macro.

Thank you for the explanation. The logic is understandable from your changes - but I don't understand the underlying problem.

Can you explain why can't we link the malloc() override into DSO? What is the problem with linker or dynamic loader, if we do otherwise?

Can you explain why can't we link the malloc() override into DSO? What is the problem with linker or dynamic loader, if we do otherwise?

Most likely because it might fail to load in time upon starting.

Maybe it is dependency issue. If all .so that do malloc/free depend on .so that provide overrides, this .so must be loaded beforehand.

Tbh, I still don't have a clear mind of all other broken cases, but the way in current PR should work. I've asked for a minimal broken example in jemalloc/jemalloc#1636 . Hopefully we can get a better idea of what might go wrong when linking to a DSO containing jemalloc symbols.

Tbh, I still don't have a clear mind of all other broken cases, but the way in current PR should work. I've asked for a minimal broken example in jemalloc/jemalloc#1636 . Hopefully we can get a better idea of what might go wrong when linking to a DSO containing jemalloc symbols.

I will make a little investigation today, and will post if I find anything.