Enable JIT compilation for more expressions by taiyang-li · Pull Request #70598 · ClickHouse/ClickHouse

taiyang-li · 2024-10-12T10:03:31Z

Changelog category (leave one):

Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Enable JIT compilation for more expressions: abs/bitCount/sign/modulo/pmod/isNull/isNotNull/assumeNotNull/to(U)Int*/toFloat*, comparison functions(=, <, >, >=, <=), logical functions(and, or).

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

Allow: All Required Checks
Allow: Stateless tests
Allow: Stateful tests
Allow: Integration Tests
Allow: Performance tests
Allow: All Builds
Allow: batch 1, 2 for multi-batch jobs
Allow: batch 3, 4, 5, 6 for multi-batch jobs

Exclude: Style check
Exclude: Fast test
Exclude: All with ASAN
Exclude: All with TSAN, MSAN, UBSAN, Coverage
Exclude: All with aarch64, release, debug

Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
Exclude: AST fuzzers

taiyang-li · 2024-10-12T10:06:21Z

First prepare data

CREATE TABLE jit_test (
a UInt64,
b UInt64,
c UInt64,
d UInt64,
e UInt64,
f UInt64,
g UInt64,
h UInt64,
i UInt64,
j UInt64
) Engine = Memory

INSERT INTO jit_test
SELECT
number,
number,
number,
number,
number,
number,
number,
number,
number,
number
FROM
system.numbers
LIMIT 100000000

For abs

SELECT abs(-a) / abs(b) + abs(c) / abs(d) + abs(-e) / abs(f) + abs(g) / abs(h) + abs(-i) / abs(j) FROM jit_test SETTINGS compile_expressions = 0 format Null; 
0 rows in set. Elapsed: 0.607 sec. Processed 100.00 million rows, 8.00 GB (164.87 million rows/s., 13.19 GB/s.)

SELECT abs(-a) / abs(b) + abs(c) / abs(d) + abs(-e) / abs(f) + abs(g) / abs(h) + abs(-i) / abs(j) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null; 
0 rows in set. Elapsed: 0.159 sec. Processed 100.00 million rows, 8.00 GB (628.62 million rows/s., 50.29 GB/s.)

For bitcount

SELECT bitCount(a) + bitCount(b) + bitCount(c) + bitCount(d) + bitCount(e) + bitCount(f) + bitCount(g)+ bitCount(h)+ bitCount(i) + bitCount(j) FROM jit_test SETTINGS compile_expressions = 0 format Null; 
0 rows in set. Elapsed: 0.281 sec. Processed 100.00 million rows, 8.00 GB (355.82 million rows/s., 28.47 GB/s.)

SELECT bitCount(a) + bitCount(b) + bitCount(c) + bitCount(d) + bitCount(e) + bitCount(f) + bitCount(g)+ bitCount(h)+ bitCount(i) + bitCount(j)  FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null; 
0 rows in set. Elapsed: 0.137 sec. Processed 100.00 million rows, 8.00 GB (728.95 million rows/s., 58.32 GB/s.)

robot-ch-test-poll2 · 2024-10-12T10:06:47Z

This is an automated comment for commit 0e82fb8 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

taiyang-li · 2024-10-12T10:37:08Z

For sign

 
without compilation: SELECT sign(a) + sign(b) + sign(c) + sign(d) + sign(e) + sign(f) + sign(g) + sign(h) + sign(i) + sign(j) FROM jit_test SETTINGS compile_expressions = 0 format Null; 

localhost:9001, queries: 20, QPS: 3.522, RPS: 352227623.681, MiB/s: 26872.835, result RPS: 0.000, result MiB/s: 0.000


with compilation: SELECT sign(a) + sign(b) + sign(c) + sign(d) + sign(e) + sign(f) + sign(g) + sign(h) + sign(i) + sign(j) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null; 

localhost:9001, queries: 20, QPS: 7.372, RPS: 737213493.089, MiB/s: 56244.926, result RPS: 0.000, result MiB/s: 0.000.

taiyang-li · 2024-10-14T03:21:57Z

For comparison functions, execution with JIT is slightly slower.

SELECT equals(a, b/g) + less(c, d/g) + greater(e/g, f) FROM jit_test SETTINGS compile_expressions = 0 format Null; 
localhost:9001, queries: 20, QPS: 4.426, RPS: 442635961.679, MiB/s: 23639.311, result RPS: 0.000, result MiB/s: 0.000.


SELECT equals(a, b/g) + less(c, d/g) + greater(e/g, f) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
localhost:9001, queries: 20, QPS: 4.387, RPS: 438709117.961, MiB/s: 23429.595, result RPS: 0.000, result MiB/s: 0.000.

For isNotNull:

SELECT isNotNull(a::Nullable(UInt64)) + isNotNull(b::Nullable(UInt64)) + isNotNull(c::Nullable(UInt64)) + isNotNull(d::Nullable(UInt64)) + isNotNull(e::Nullable(UInt64)) + isNotNull(f::Nullable(UInt64)) + isNotNull(g::Nullable(UInt64)) FROM jit_test SETTINGS compile_expressions = 0 format Null;
0 rows in set. Elapsed: 0.120 sec. Processed 100.00 million rows, 5.60 GB (836.18 million rows/s., 46.83 GB/s.)

SELECT isNotNull(a::Nullable(UInt64)) + isNotNull(b::Nullable(UInt64)) + isNotNull(c::Nullable(UInt64)) + isNotNull(d::Nullable(UInt64)) + isNotNull(e::Nullable(UInt64)) + isNotNull(f::Nullable(UInt64)) + isNotNull(g::Nullable(UInt64)) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.064 sec. Processed 100.00 million rows, 5.60 GB (1.55 billion rows/s., 87.00 GB/s.)

For assumeNotNull

SELECT assumeNotNull(a::Nullable(UInt64)) + assumeNotNull(b::Nullable(UInt64)) + assumeNotNull(c::Nullable(UInt64)) + assumeNotNull(d::Nullable(UInt64)) + assumeNotNull(e::Nullable(UInt64)) + assumeNotNull(f::Nullable(UInt64)) + assumeNotNull(g::Nullable(UInt64)) FROM jit_test SETTINGS compile_expressions = 0 format Null;
0 rows in set. Elapsed: 0.166 sec. Processed 100.00 million rows, 5.60 GB (602.55 million rows/s., 33.74 GB/s.) 

SELECT assumeNotNull(a::Nullable(UInt64)) + assumeNotNull(b::Nullable(UInt64)) + assumeNotNull(c::Nullable(UInt64)) + assumeNotNull(d::Nullable(UInt64)) + assumeNotNull(e::Nullable(UInt64)) + assumeNotNull(f::Nullable(UInt64)) + assumeNotNull(g::Nullable(UInt64)) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.066 sec. Processed 100.00 million rows, 5.60 GB (1.51 billion rows/s., 84.78 GB/s.)

For and

SELECT and(a::Nullable(UInt64), b::Nullable(UInt64)) + and(c::Nullable(UInt64), d::Nullable(UInt64)) + and(e::Nullable(UInt64), f::Nullable(UInt64)) + g::Nullable(UInt64) FROM jit_test SETTINGS compile_expressions = 0 format Null;
localhost:9001, queries: 20, QPS: 4.661, RPS: 466084590.184, MiB/s: 24891.603, result RPS: 0.000, result MiB/s: 0.000.

SELECT and(a::Nullable(UInt64), b::Nullable(UInt64)) + and(c::Nullable(UInt64), d::Nullable(UInt64)) + and(e::Nullable(UInt64), f::Nullable(UInt64)) + g::Nullable(UInt64) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
localhost:9001, queries: 20, QPS: 5.143, RPS: 514327996.044, MiB/s: 27468.078, result RPS: 0.000, result MiB/s: 0.000.

For or

SELECT or(a::Nullable(UInt64), b::Nullable(UInt64)) + or(c::Nullable(UInt64), d::Nullable(UInt64)) + or(e::Nullable(UInt64), f::Nullable(UInt64)) + g::Nullable(UInt64) FROM jit_test SETTINGS compile_expressions = 0 format Null;
localhost:9001, queries: 20, QPS: 6.569, RPS: 656907149.117, MiB/s: 35082.627, result RPS: 0.000, result MiB/s: 0.000.

SELECT or(a::Nullable(UInt64), b::Nullable(UInt64)) + or(c::Nullable(UInt64), d::Nullable(UInt64)) + or(e::Nullable(UInt64), f::Nullable(UInt64)) + g::Nullable(UInt64) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
localhost:9001, queries: 20, QPS: 7.087, RPS: 708686555.439, MiB/s: 37847.945, result RPS: 0.000, result MiB/s: 0.000.

For xor

SELECT xor(a::Nullable(UInt64), b::Nullable(UInt64)) + xor(c::Nullable(UInt64), d::Nullable(UInt64)) + xor(e::Nullable(UInt64), f::Nullable(UInt64)) + g::Nullable(UInt64) FROM jit_test SETTINGS compile_expressions = 0 format Null;
localhost:9001, queries: 20, QPS: 8.167, RPS: 816676282.063, MiB/s: 43615.219, result RPS: 0.000, result MiB/s: 0.000.

SELECT xor(a::Nullable(UInt64), b::Nullable(UInt64)) + xor(c::Nullable(UInt64), d::Nullable(UInt64)) + xor(e::Nullable(UInt64), f::Nullable(UInt64)) + g::Nullable(UInt64) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null
localhost:9001, queries: 20, QPS: 12.297, RPS: 1229676512.222, MiB/s: 65671.811, result RPS: 0.000, result MiB/s: 0.000.

…n to 1

taiyang-li · 2024-10-14T10:17:41Z

For isNull:

SELECT isNull(a::Nullable(UInt64)) + isNull(b::Nullable(UInt64)) + isNull(c::Nullable(UInt64)) + isNull(d::Nullable(UInt64)) + isNull(e::Nullable(UInt64)) + isNull(f::Nullable(UInt64)) + isNull(g::Nullable(UInt64)) FROM jit_test SETTINGS compile_expressions = 0 format Null;
0 rows in set. Elapsed: 0.118 sec. Processed 100.00 million rows, 5.60 GB (849.83 million rows/s., 47.59 GB/s.)
SELECT isNull(a::Nullable(UInt64)) + isNull(b::Nullable(UInt64)) + isNull(c::Nullable(UInt64)) + isNull(d::Nullable(UInt64)) + isNull(e::Nullable(UInt64)) + isNull(f::Nullable(UInt64)) + isNull(g::Nullable(UInt64)) FROM jit_test SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.063 sec. Processed 100.00 million rows, 5.60 GB (1.60 billion rows/s., 89.57 GB/s.)

For modulo

SELECT modulo(a::Nullable(UInt64), b::Nullable(UInt64)) + modulo(c::Nullable(UInt64), d::Nullable(UInt64)) + modulo(e::Nullable(UInt64), f::Nullable(UInt64)) FROM jit_test where a != 0 SETTINGS compile_expressions = 0 format Null
0 rows in set. Elapsed: 0.501 sec. Processed 200.00 million rows, 9.60 GB (399.09 million rows/s., 19.16 GB/s.)
SELECT modulo(a::Nullable(UInt64), b::Nullable(UInt64)) + modulo(c::Nullable(UInt64), d::Nullable(UInt64)) + modulo(e::Nullable(UInt64), f::Nullable(UInt64)) FROM jit_test where a != 0 SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.198 sec. Processed 200.00 million rows, 9.60 GB (1.01 billion rows/s., 48.55 GB/s.)

For pmod

SELECT pmod(a::Nullable(UInt64), b::Nullable(UInt64)) + pmod(c::Nullable(UInt64), d::Nullable(UInt64)) + pmod(e::Nullable(UInt64), f::Nullable(UInt64)) FROM jit_test where a != 0 SETTINGS compile_expressions = 0 format Null
0 rows in set. Elapsed: 0.594 sec. Processed 200.00 million rows, 9.60 GB (336.52 million rows/s., 16.15 GB/s.)
SELECT pmod(a::Nullable(UInt64), b::Nullable(UInt64)) + pmod(c::Nullable(UInt64), d::Nullable(UInt64)) + pmod(e::Nullable(UInt64), f::Nullable(UInt64)) FROM jit_test where a != 0 SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.279 sec. Processed 200.00 million rows, 9.60 GB (717.50 million rows/s., 34.44 GB/s.)

For to(U)Int8|16|32|64 and toFloat32|64

SELECT modulo(toInt64(a), toInt64(b)) + modulo(toInt64(c), toInt64(d)) + modulo(toInt64(e), toInt64(f)) FROM jit_test where a != 0 SETTINGS compile_expressions = 0 format Null;
0 rows in set. Elapsed: 0.365 sec. Processed 100.00 million rows, 4.80 GB (273.62 million rows/s., 13.13 GB/s.)

SELECT modulo(toInt64(a), toInt64(b)) + modulo(toInt64(c), toInt64(d)) + modulo(toInt64(e), toInt64(f)) FROM jit_test where a != 0 SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.138 sec. Processed 100.00 million rows, 4.80 GB (723.66 million rows/s., 34.74 GB/s.)

For identity

SELECT plus(identity(cast(a as Nullable(Int64))), identity(cast(b as Nullable(Int64)))) + plus(identity(cast(c as Nullable(Int64))), identity(cast(d as Nullable(Int64)))) + plus(identity(cast(e as Nullable(Int64))), identity(cast(f as Nullable(Int64)))) FROM jit_test where a != 0 SETTINGS compile_expressions = 0 format Null;
0 rows in set. Elapsed: 0.373 sec. Processed 100.00 million rows, 4.80 GB (268.40 million rows/s., 12.88 GB/s.)
SELECT plus(identity(cast(a as Nullable(Int64))), identity(cast(b as Nullable(Int64)))) + plus(identity(cast(c as Nullable(Int64))), identity(cast(d as Nullable(Int64)))) + plus(identity(cast(e as Nullable(Int64))), identity(cast(f as Nullable(Int64)))) FROM jit_test where a != 0 SETTINGS compile_expressions = 1, min_count_to_compile_expression = 0 format Null;
0 rows in set. Elapsed: 0.287 sec. Processed 100.00 million rows, 4.80 GB (348.48 million rows/s., 16.73 GB/s.)

geldot · 2024-11-15T02:40:29Z

Yes, I remember - when we enabled it on AArch64, LLVM crashed. That's why we cannot enable this setting by default.

The LLVM library in our repository is old and has to be updated.

For reference, initial attempt to bump LLVM from 15 to 16 is at #69654 (which focuses on updating libcxx, so unclear if JIT still works with patch). Latest LLVM stable release appears to be 19. Unknown if these resolve the AArch64 issue.

Algunenano · 2024-11-15T13:17:45Z

I still don't see any link to llvm issue, so assuming an update to LLVM fixes anything is a long stretch. It might be a problem in our code

nickitat · 2024-11-15T18:00:25Z

@taiyang-li could you pls update this branch. i cannot push into it. loongarch build should be fixed then.

alexey-milovidov · 2024-11-15T21:10:29Z

LLVM JIT has a long track record of bugs; it is generally not safe. I'd bet (but not much) that it could be fixed in the recent versions.

taiyang-li · 2024-11-18T07:16:41Z

failed uts seem not related:

taiyang-li · 2024-11-19T03:47:17Z

@nickitat I didn't mean to urge, just curious when can this PR ready to be merged?

nickitat · 2024-11-19T12:15:27Z

@taiyang-li could you pls update this branch. i cannot push into it. loongarch build should be fixed then.

i meant it was already fixed in master by Alexey. this commit is not needed. pls remove it

taiyang-li · 2024-11-21T01:09:47Z

@taiyang-li could you pls update this branch. i cannot push into it. loongarch build should be fixed then.

i meant it was already fixed in master by Alexey. this commit is not needed. pls remove it

done.

src/Functions/FunctionsComparison.h

taiyang-li · 2024-11-28T02:17:30Z

@nickitat @geldot all the test had been passed, the pr is ready for review now, thanks!

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241129) * Fix Build AND UT Due to [Added cache for primary index](ClickHouse/ClickHouse#72102) * Fix Build and UT due to [no auto write buffer finalization in destructors](ClickHouse/ClickHouse#68800) - Make LocalPartitionWriter::evictPartitions called, e.g. set(GlutenConfig.COLUMNAR_CH_SHUFFLE_SPILL_THRESHOLD.key, (1024*1024).toString) * Fix Build due to [Save several minutes of build time](ClickHouse/ClickHouse#72046) * Fix Benchmark Build due to [Scatter blocks in hash join without copying](ClickHouse/ClickHouse#67782) (cherry picked from commit 8d566d6a8b8785e4072ffd6f774eb83b07ac3d8d) * Fix Benchmark Build * Fix endless loop due to ClickHouse/ClickHouse#70598 * [Refactor #8100] using CHConf.setCHConfig() * fix style --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>

Algunenano · 2024-12-10T11:22:50Z

Crashes have been found: #72936

SELECT 1023, (((id % -9223372036854775807) = NULL) OR ((id % NULL) = 100)) = ((id % inf) = toUInt128(9223372036854775806)), (id % NULL) = NULL, (id % materialize(toNullable(3.4028234663852886e38)))

taiyang-li · 2024-12-11T01:13:38Z

@Algunenano I'll try to fix it.

taiyang-li · 2024-12-20T01:45:46Z

Crashes have been found: #72936

SELECT 1023, (((id % -9223372036854775807) = NULL) OR ((id % NULL) = 100)) = ((id % inf) = toUInt128(9223372036854775806)), (id % NULL) = NULL, (id % materialize(toNullable(3.4028234663852886e38)))

It is fixed in #73509 .

taiyang-li added 2 commits October 12, 2024 15:21

enable jit for abs

7ab71ec

enable jit for bitCount

e5886d4

taiyang-li marked this pull request as draft October 12, 2024 10:04

robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Oct 12, 2024

taiyang-li added 4 commits October 13, 2024 08:58

support sign compilation

ae3b3fe

jit for compare functions

98d9077

enable jit for comparision functions

61de692

enable jit for isnotnull

f407180

alexey-milovidov added the can be tested Allows running workflows for external contributors label Oct 13, 2024

robot-ch-test-poll2 added pr-performance Pull request with some performance improvements and removed pr-feature Pull request with new product feature labels Oct 13, 2024

taiyang-li added 3 commits October 13, 2024 18:09

enable jit for assumenotnull

f28836a

enable jit for and/or/xor

fd43dcb

fix style

a8e905b

taiyang-li marked this pull request as ready for review October 14, 2024 03:17

fix style

3405fb9

taiyang-li added 3 commits October 14, 2024 11:28

fix typo

5349511

fix building

782a13b

fix bugs

458872b

nickitat self-assigned this Oct 14, 2024

turn on expression compilation and set min_count_to_compile_expressio…

47971c9

…n to 1

taiyang-li added 2 commits October 15, 2024 09:03

support jit for identity

664f565

fix incompatiable history

7fd58a7

taiyang-li mentioned this pull request Oct 15, 2024

[CH] Optimize sparkDecimalXXX functions and support more expressions for JIT apache/gluten#7534

Closed

Merge branch 'master' into more_jits

91ac8ff

nickitat approved these changes Nov 14, 2024

View reviewed changes

fix conflicts

bcc2a31

fix conflicts

7a74f02

taiyang-li force-pushed the more_jits branch from aa11786 to 7a74f02 Compare November 21, 2024 01:09

solve conflicts

70f2a87

geldot reviewed Nov 27, 2024

View reviewed changes

src/Functions/FunctionsComparison.h Outdated Show resolved Hide resolved

taiyang-li added 3 commits November 27, 2024 14:38

add functionsconversions

344000e

change as request

b069aa3

fix building

0e82fb8

nickitat enabled auto-merge November 28, 2024 15:29

nickitat added this pull request to the merge queue Nov 28, 2024

Merged via the queue into ClickHouse:master with commit f3f41d8 Nov 28, 2024

robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 28, 2024

baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 29, 2024

Fix endless loop due to ClickHouse/ClickHouse#70598

9eb3b76

Algunenano mentioned this pull request Dec 9, 2024

Assertion getOperand(0)->getType() == getOperand(1)->getType() && "Both operands to ICmp instruction are not of the same type!"' failed` #72936

Closed

Algunenano mentioned this pull request Dec 10, 2024

Revert "Enable JIT compilation for more expressions" #73010

Merged

Conversation

taiyang-li commented Oct 12, 2024 • edited by nickitat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI Settings (Only check the boxes if you know what you are doing):

Uh oh!

taiyang-li commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robot-ch-test-poll2 commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taiyang-li commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taiyang-li commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taiyang-li commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geldot commented Nov 15, 2024

Uh oh!

Algunenano commented Nov 15, 2024

Uh oh!

nickitat commented Nov 15, 2024

Uh oh!

alexey-milovidov commented Nov 15, 2024

Uh oh!

taiyang-li commented Nov 18, 2024

Uh oh!

taiyang-li commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickitat commented Nov 19, 2024

Uh oh!

taiyang-li commented Nov 21, 2024

Uh oh!

Uh oh!

taiyang-li commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Algunenano commented Dec 10, 2024

Uh oh!

taiyang-li commented Dec 11, 2024

Uh oh!

taiyang-li commented Dec 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

taiyang-li commented Oct 12, 2024 •

edited by nickitat

Loading

taiyang-li commented Oct 12, 2024 •

edited

Loading

robot-ch-test-poll2 commented Oct 12, 2024 •

edited

Loading

taiyang-li commented Oct 12, 2024 •

edited

Loading

taiyang-li commented Oct 14, 2024 •

edited

Loading

taiyang-li commented Oct 14, 2024 •

edited

Loading

taiyang-li commented Nov 19, 2024 •

edited

Loading

taiyang-li commented Nov 28, 2024 •

edited

Loading