Revert "JSONCompactWithProgress query output format"#69989
Merged
alexey-milovidov merged 1 commit intomasterfrom Sep 26, 2024
Merged
Revert "JSONCompactWithProgress query output format"#69989alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
alexey-milovidov
deleted the
revert-66205-output-format-json-compact-with-progress
branch
robot-ch-test-poll3
added
the
pr-synced-to-cloud
robot-clickhouse
added a commit
that referenced
this pull request
Sep 26, 2024
robot-ch-test-poll3
added
the
pr-backports-created
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Sep 26, 2024
Backport #69989 to 24.9: Revert "JSONCompactWithProgress query output format"
Contributor
|
@alexey-milovidov - is there an open issue for the underlying problem with flushing progress? Should I open one? |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #66205
@Algunenano, Basic testing shown that it does not work as intended:
@Algunenano
JSONCompactWithProgress does not work in clickhouse-local:
https://pastila.nl/?0024596c/d039cc99db3cc026de2afeb283771e72#x1s8sFhPOSCAPko0dGFHAw==
Whitespaces are weirdly inconsistent in different elements.
The data is not flushed on every progress packet in clickhouse-client, which defeats the purpose:
https://pastila.nl/?000055ae/75b3d3ea4b6c667b7ea188b2dbf75535#vrQYam7YEVr3JUVWTuFIKg==
(everything was displayed in a single step after 20 sec)
No... it does not even work in curl 😞