Skip to content

Resubmit #63279#69861

Merged
vdimir merged 5 commits intomasterfrom
vdimir/fix-mongo-cxx-driver-gen
Sep 24, 2024
Merged

Resubmit #63279#69861
vdimir merged 5 commits intomasterfrom
vdimir/fix-mongo-cxx-driver-gen

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Sep 23, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@vdimir vdimir self-assigned this Sep 23, 2024
@robot-clickhouse robot-clickhouse added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Sep 23, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Sep 23, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 4cae201 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir force-pushed the vdimir/fix-mongo-cxx-driver-gen branch from fa857c7 to 987635c Compare September 23, 2024 12:49
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Sep 23, 2024

@vdimir It also looks like this PR broke some tests while was in master https://s3.amazonaws.com/clickhouse-test-reports/0/1b77b438fdfa44f9641c6a65fc4dcf5e6ad82fb5/integration_tests__asan__[3_4]//home/ubuntu/actions-runner/_work/_temp/test/output_dir/integration_run_parallel1_0.log

Let's make sure it won't happen again after merge...

@vdimir vdimir added this pull request to the merge queue Sep 24, 2024
Merged via the queue into master with commit b858595 Sep 24, 2024
@vdimir vdimir deleted the vdimir/fix-mongo-cxx-driver-gen branch September 24, 2024 12:21
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 24, 2024
Algunenano
Algunenano reviewed Sep 24, 2024
View reviewed changes
src/Core/SettingsChangesHistory.cpp
{"join_to_sort_maximum_table_rows", 0, 10000, "The maximum number of rows in the right table to determine whether to rerange the right table by key in left or inner join"},
{"allow_experimental_join_right_table_sorting", false, false, "If it is set to true, and the conditions of `join_to_sort_minimum_perkey_rows` and `join_to_sort_maximum_table_rows` are met, rerange the right table by key to improve the performance in left or inner hash join"}
{"allow_experimental_join_right_table_sorting", false, false, "If it is set to true, and the conditions of `join_to_sort_minimum_perkey_rows` and `join_to_sort_maximum_table_rows` are met, rerange the right table by key to improve the performance in left or inner hash join"},
{"mongodb_throw_on_unsupported_query", false, true, "New setting."},
Copy link
Copy Markdown
Member

@Algunenano Algunenano Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in 24.10

Copy link
Copy Markdown
Member

@Algunenano Algunenano Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#69913

github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
@nikitamikhaylov
Merge pull request #69930 from ClickHouse/vdimir/fix-mongo-c-driver-bld
cdae520 
Followup for #69861
@yariks5s
Copy link
Copy Markdown
Member

yariks5s commented Nov 4, 2024

I have this segfault in TableFunctionMongoDB:

(version 24.8.1.10338 (official build), build id: 3CA873258A46DC00BB708FDE4D68F10BF7494C07, git hash: 1463c1f269f8b41656fea6aa399bf80ec8060574) (from thread 862) (query_id: c4ebbcb7-d443-4273-a049-fa0d5cad5ac8) (query: SELECT * FROM mongodb('mongodb://movedb.cluster-cohxzo0c14le.eu-west-1.docdb.amazonaws.com:27017/?retryWrites=false&readPreference=secondaryPreferred&replicaSet=rs0&tls=true&tlsCAFile=%2Fhome%2Fkevin%2Fmongo%2Fglobal-bundle.pem', 'deck_gotest', 'ppvs', 'MoveSolutions', '[HIDDEN]', NULL)) Received signal Segmentation fault (11)

Address: 0xdf. Access: . Address not mapped to object.

0. signalHandler(int, siginfo_t*, void*)
1. ?
2. DB::(anonymous namespace)::TableFunctionMongoDB::parseArguments(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context const>)
3. DB::QueryAnalyzer::resolveTableFunction(std::shared_ptr<DB::IQueryTreeNode>&, DB::IdentifierResolveScope&, DB::QueryExpressionsAliasVisitor&, bool)
4. DB::QueryAnalyzer::resolveQueryJoinTreeNode(std::shared_ptr<DB::IQueryTreeNode>&, DB::IdentifierResolveScope&, DB::QueryExpressionsAliasVisitor&)
5. DB::QueryAnalyzer::resolveQuery(std::shared_ptr<DB::IQueryTreeNode> const&, DB::IdentifierResolveScope&)
6. DB::QueryAnalyzer::resolve(std::shared_ptr<DB::IQueryTreeNode>&, std::shared_ptr<DB::IQueryTreeNode> const&, std::shared_ptr<DB::Context const>)
7. DB::QueryAnalysisPass::run(std::shared_ptr<DB::IQueryTreeNode>&, std::shared_ptr<DB::Context const>)
8. DB::QueryTreePassManager::run(std::shared_ptr<DB::IQueryTreeNode>)
9. DB::(anonymous namespace)::buildQueryTreeAndRunPasses(std::shared_ptr<DB::IAST> const&, DB::SelectQueryOptions const&, std::shared_ptr<DB::Context const> const&, std::shared_ptr<DB::IStorage> const&) (.llvm.9215533484892928605)
10. DB::InterpreterSelectQueryAnalyzer::InterpreterSelectQueryAnalyzer(std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context const> const&, DB::SelectQueryOptions const&, std::vector<String, std::allocator<String>> const&)
11. std::unique_ptr<DB::IInterpreter, std::default_delete<DB::IInterpreter>> std::__function::__policy_invoker<std::unique_ptr<DB::IInterpreter, std::default_delete<DB::IInterpreter>> (DB::InterpreterFactory::Arguments const&)>::__call_impl<std::__function::__default_alloc_func<DB::registerInterpreterSelectQueryAnalyzer(DB::InterpreterFactory&)::$_0, std::unique_ptr<DB::IInterpreter, std::default_delete<DB::IInterpreter>> (DB::InterpreterFactory::Arguments const&)>>(std::__function::__policy_storage const*, DB::InterpreterFactory::Arguments const&) (.llvm.9215533484892928605)
12. DB::InterpreterFactory::get(std::shared_ptr<DB::IAST>&, std::shared_ptr<DB::Context>, DB::SelectQueryOptions const&)
13. DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*)
14. DB::executeQuery(DB::ReadBuffer&, DB::WriteBuffer&, bool, std::shared_ptr<DB::Context>, std::function<void (DB::QueryResultDetails const&)>, DB::QueryFlags, std::optional<DB::FormatSettings> const&, std::function<void (DB::IOutputFormat&, String const&, std::shared_ptr<DB::Context const> const&, std::optional<DB::FormatSettings> const&)>)
15. DB::HTTPHandler::processQuery(DB::HTTPServerRequest&, DB::HTMLForm&, DB::HTTPServerResponse&, DB::HTTPHandler::Output&, std::optional<DB::CurrentThread::QueryScope>&, StrongTypedef<unsigned long, ProfileEvents::EventTag> const&)
16. DB::HTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&, StrongTypedef<unsigned long, ProfileEvents::EventTag> const&)
17. DB::HTTPServerConnection::run()
18. DB::TCPProtocolStackHandler::run()
19. Poco::Net::TCPServerConnection::start()
20. Poco::Net::TCPServerDispatcher::run()
21. Poco::PooledThread::run()
22. Poco::ThreadImpl::runnableEntry(void*)
23. ?
24. ?

It can be connected to this PR.

@yariks5s
Copy link
Copy Markdown
Member

yariks5s commented Nov 4, 2024

cc @vdimir

@Algunenano Algunenano mentioned this pull request Nov 4, 2024
Closed
@ianton-ru ianton-ru mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

Assignees

@vdimir vdimir

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vdimir @robot-clickhouse-ci-1 @nikitamikhaylov @yariks5s @Algunenano @robot-clickhouse