Bump llvm to 16.x by rschu1ze · Pull Request #69654 · ClickHouse/ClickHouse

rschu1ze · 2024-09-16T20:51:12Z

I made an amateurish attempt to switch to the new pass manager based on the tutorial. The legacy pass manager will be removed in LLVM >= 16. Chances are that something messes up.

The main benefit of this PR is that it enables the new libcxx.

Supersedes #66053 and #47783.

Necessary fixes in LLVM: https://github.com/ClickHouse/llvm-project/commits/ClickHouse/llvmorg-16.0.6
Necessary fixes in rocksdb: https://github.com/ClickHouse/rocksdb/commits/ClickHouse/v9.4.0/

Changelog category (leave one):

Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Bumped LLVM to 16 version. This is an internal dependency.

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

Allow: All Required Checks
Allow: Stateless tests
Allow: Stateful tests
Allow: Integration Tests
Allow: Performance tests
Allow: All Builds
Allow: batch 1, 2 for multi-batch jobs
Allow: batch 3, 4, 5, 6 for multi-batch jobs

Exclude: Style check
Exclude: Fast test
Exclude: All with ASAN
Exclude: All with TSAN, MSAN, UBSAN, Coverage
Exclude: All with aarch64, release, debug

Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
Exclude: AST fuzzers

robot-ch-test-poll2 · 2024-09-16T20:53:57Z

This is an automated comment for commit dd54e3b with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

nikitamikhaylov · 2024-12-21T16:40:18Z

There are several notable changes in performance:
Tests reports for ARM are here: 1, 2, 3, 4
Slowdowns: jit_small_requests - 40%, int_parsing - 10%, and_function - 20%, float_formatting - 30%.
Speedups: vectorize_aggregation_combinators - 50%, rand - 50%, decimal_casts - 15%

For the float_formatting I've did some analysis and I see nothing suspicious in perf-top.

  38,04%  clickhouse        [.] unsigned long DB::writeFloatTextFastPath<double>(double, char*) requires is_floating_point<double>                                                                                                                                                                                                               ◆
  23,20%  clickhouse        [.] DB::WriteBuffer::write(char)                                                                                                                                                                                                                                                                                     ▒
  18,45%  clickhouse        [.] COW<DB::IColumn>::immutable_ptr<DB::IColumn> DB::detail::ConvertImpl<DB::DataTypeNumber<double>, DB::DataTypeString, DB::detail::NameToString, (DB::FormatSettings::DateTimeOverflowBehavior)0>::execute<void*>(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > cons▒
   8,82%  clickhouse        [.] itoa(long, char*)                                                                                                                                                                                                                                                                                                ▒
   4,45%  clickhouse        [.] COW<DB::IColumn>::immutable_ptr<DB::IColumn> DB::detail::ConvertImpl<DB::DataTypeNumber<char8_t>, DB::DataTypeNumber<double>, DB::detail::NameToFloat64, (DB::FormatSettings::DateTimeOverflowBehavior)0>::execute<void*>(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndNa▒
   2,65%  clickhouse        [.] DB::(anonymous namespace)::ModuloByConstantImpl<unsigned long, char8_t>::vectorConstant(unsigned long const*, char8_t, char8_t*, unsigned long)                                                                                                                                                                  ▒
   1,40%  clickhouse        [.] _ZN2DBL12iotaImplAVX2ITkNS_20iota_supported_typesEmEEvPT_mS1_

Test reports for x86 are here: 1, 2, 3, 4
Slowdowns: jit_large_requests - 80%, jit_small_requests - 50%.

Looks like JIT's new infra is much more slow, but I guess this is Ok, because we have compile_expressions setting disabled by default. Not sure what to do and how to investigate other tests. I will also check LLVM-18 in another PR.

…e#66053 since ch bump llvm to 18, which cause building CurrentMemoryTracker.h is failed, I remove two unecessary commits: - Kyligence/ClickHouse#488 - Kyligence/ClickHouse@1922234

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241224) * Fix Build due to ClickHouse/ClickHouse#69654 and ClickHouse/ClickHouse#66053 since ch bump llvm to 18, which cause building CurrentMemoryTracker.h is failed, I remove two unecessary commits: - Kyligence/ClickHouse#488 - Kyligence/ClickHouse@1922234 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>

robot-clickhouse-ci-1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Sep 16, 2024

rschu1ze mentioned this pull request Oct 17, 2024

(Re?)-enable libcxx asserts for debug builds #70134

Merged

This comment was marked as resolved.

Sign in to view

geldot mentioned this pull request Nov 15, 2024

Enable JIT compilation for more expressions #70598

Merged

21 tasks

This comment was marked as resolved.

Sign in to view

taiyang-li mentioned this pull request Dec 18, 2024

[GLUTEN-7534][CH] Refactor and optimize sparkDecimalXXX functions apache/gluten#8105

Merged

nikitamikhaylov force-pushed the bump-llvm branch from 1b6787d to af77fc9 Compare December 19, 2024 15:50

nikitamikhaylov marked this pull request as ready for review December 20, 2024 20:22

nikitamikhaylov mentioned this pull request Dec 20, 2024

Bump llvm-project to 18.x #66053

Merged

19 tasks

nikitamikhaylov force-pushed the bump-llvm branch from e50d16c to 9e15c2b Compare December 20, 2024 22:25

robot-clickhouse added pr-performance Pull request with some performance improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Dec 20, 2024

robot-ch-test-poll4 added pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-performance Pull request with some performance improvements labels Dec 21, 2024

rschu1ze and others added 11 commits December 22, 2024 00:48

Bump llvm to 16.x

5df84d7

Fix build

30a48f7

Fix funny tests failure

4efd408

Try to replace std::aligned_union-T

850ea26

Fix build

605824d

Replaced std::aligned_storage

5da2722

Fix self-extracting executable util

11292be

Fix decompressor

a6d5854

Bump submodule

afd3f94

Bump submodule [2]

0215b08

Remove commented code

a125e7b

nikitamikhaylov and others added 4 commits December 22, 2024 00:48

Fixed test

f56b10f

Change the optimization level to O3

8137f3a

Bump

f1a13bf

Fix test 01720_country_perimeter_and_area

dd54e3b

nikitamikhaylov force-pushed the bump-llvm branch from b4f9cd7 to dd54e3b Compare December 21, 2024 23:48

nikitamikhaylov self-assigned this Dec 22, 2024

nikitamikhaylov approved these changes Dec 23, 2024

View reviewed changes

nikitamikhaylov added this pull request to the merge queue Dec 23, 2024

Merged via the queue into ClickHouse:master with commit 1f97cfd Dec 23, 2024

robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 23, 2024

rschu1ze mentioned this pull request Feb 24, 2025

Use our own assertion handling for libcxx hardening #76701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump llvm to 16.x#69654

Bump llvm to 16.x#69654
nikitamikhaylov merged 15 commits intoClickHouse:masterfrom
rschu1ze:bump-llvm

rschu1ze commented Sep 16, 2024 •

edited by nikitamikhaylov

Loading

Uh oh!

robot-ch-test-poll2 commented Sep 16, 2024 •

edited

Loading

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

nikitamikhaylov commented Dec 21, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

rschu1ze commented Sep 16, 2024 • edited by nikitamikhaylov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI Settings (Only check the boxes if you know what you are doing):

Uh oh!

robot-ch-test-poll2 commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

nikitamikhaylov commented Dec 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rschu1ze commented Sep 16, 2024 •

edited by nikitamikhaylov

Loading

robot-ch-test-poll2 commented Sep 16, 2024 •

edited

Loading

nikitamikhaylov commented Dec 21, 2024 •

edited

Loading