Add LIMIT clause to SHOW queries#6944
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom Sep 17, 2019
Merged
Conversation
alexey-milovidov
approved these changes
Sep 16, 2019
Member
|
Ok. PS. The test relies on assumption that tables are listed in alphabetical order. And this assumption is true (whenever it become false, the test will show it). |
Member
|
@Akazz to check test failure that is unrelated to this PR. |
Akazz
approved these changes
Sep 17, 2019
Contributor
Akazz
left a comment
Akazz
left a comment
There was a problem hiding this comment.
Both failures are completely unrelated to the proposed changes:
In the former failed test run there is an issue with CH test server crashing under tsan, and in the latter - another unexpected failure of a test. I downloaded the log files, so that this PR can be safely merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Now SHOW query includes LIMIT option.
#6612