[RFC] Hide Settings implementation#69213
Conversation
|
This is an automated comment for commit 32de45c with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
I think this is the biggest drawback of the new approach, the rest (specifiy type, forward declare the used settings) is minor changes in my opinion. However I am happy to try this new approach, because the current approach makes horrible to edit any settings. |
a083e1e to
51f5d75
Compare
|
i wonder how much do you think could help if we just remove all |
62200d3 to
9f8e02a
Compare
ec29805 to
f3b05cc
Compare
f3b05cc to
f3df7bd
Compare
This was mostly done in #66404. I've removed a few more in this PR, and will continue in other PRs with smaller changes that won't require editing ~500 files anymore. |
|
(cherry picked from commit ee116b28b6d8f39cab22d3b6a589a69594d3ccfd)
(cherry picked from commit 77a02cd273b572672532ca99ee179fd66a6c2e4c)
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240920) * Fix build due to ClickHouse/ClickHouse#69213 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
) * [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240920) * Fix build due to ClickHouse/ClickHouse#69213 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The idea is that you can include
Settings.hto work with a Settings object, without the need to know about its internals, macros or settings declaration. Just declareextern const Settings{Type} name(as we do for ProfileEvents, ErrorCodes, etc) and use the subscript ([]) operator.Major simplifications would happen in BaseSettings once we remove direct usages.
Good points:
Bad points:
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):