Skip to content

fix logical error for empty async inserts#69080

Merged
hanfei1991 merged 4 commits intoClickHouse:masterfrom
hanfei1991:hanfei/fix-logical-error-async-insert-dup-offsets
Aug 30, 2024
Merged

fix logical error for empty async inserts#69080
hanfei1991 merged 4 commits intoClickHouse:masterfrom
hanfei1991:hanfei/fix-logical-error-async-insert-dup-offsets

Conversation

@hanfei1991
Copy link
Copy Markdown
Member

@hanfei1991 hanfei1991 commented Aug 29, 2024 •
edited
Loading

fix #67606

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

fix logical error when we have empty async insert

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@hanfei1991 hanfei1991 added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 29, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 29, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Aug 29, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit b0ecacc with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@CurtizJ CurtizJ self-assigned this Aug 29, 2024
@hanfei1991 hanfei1991 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 29, 2024
@hanfei1991 hanfei1991 enabled auto-merge August 29, 2024 22:46
@hanfei1991 hanfei1991 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into ClickHouse:master with commit a812cc0 Aug 30, 2024
@hanfei1991 hanfei1991 deleted the hanfei/fix-logical-error-async-insert-dup-offsets branch August 30, 2024 16:11
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Aug 30, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Aug 30, 2024
@robot-clickhouse
Backport #69080 to 24.3: fix logical error for empty async inserts
71a20b4
This was referenced Aug 30, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 30, 2024
@robot-clickhouse
Backport #69080 to 24.5: fix logical error for empty async inserts
9c48a02
This was referenced Aug 30, 2024
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Aug 30, 2024
@robot-clickhouse
Backport #69080 to 24.6: fix logical error for empty async inserts
259ee59
This was referenced Aug 30, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 30, 2024
@robot-clickhouse
Backport #69080 to 24.7: fix logical error for empty async inserts
fe6f313
This was referenced Aug 30, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 30, 2024
@robot-clickhouse
Backport #69080 to 24.8: fix logical error for empty async inserts
4ac1b80
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Aug 30, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 30, 2024
robot-ch-test-poll2 added a commit that referenced this pull request Aug 30, 2024
@robot-ch-test-poll2
Merge pull request #69116 from ClickHouse/backport/24.6/69080
064b70d 
Backport #69080 to 24.6: fix logical error for empty async inserts
robot-ch-test-poll added a commit that referenced this pull request Aug 30, 2024
@robot-ch-test-poll
Merge pull request #69112 from ClickHouse/backport/24.3/69080
e646b61 
Backport #69080 to 24.3: fix logical error for empty async inserts
robot-ch-test-poll2 added a commit that referenced this pull request Aug 30, 2024
@robot-ch-test-poll2
Merge pull request #69118 from ClickHouse/backport/24.7/69080
b4298a7 
Backport #69080 to 24.7: fix logical error for empty async inserts
robot-clickhouse-ci-1 added a commit that referenced this pull request Aug 30, 2024
@robot-clickhouse-ci-1
Merge pull request #69120 from ClickHouse/backport/24.8/69080
617ee89 
Backport #69080 to 24.8: fix logical error for empty async inserts
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 31, 2024
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Sep 2, 2024
@arthurpassos
Copy link
Copy Markdown
Contributor

arthurpassos commented Sep 2, 2024

I still see this exception https://s3.amazonaws.com/clickhouse-test-reports/65277/0bf95655aa79b4dca642a08d0fab2666fb2e0bf7/stateless_tests__asan__[2_2]/clickhouse-server.err.log

2024.09.02 11:16:02.911876 [ 1178 ] {} <Fatal> : Logical error: 'Received from kng4alm55c.us-east-2.aws.clickhouse-staging.com:9440. DB::Exception: Unexpected error for async deduplicated insert, please check error logs. Stack trace:

0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000c3f0684
1. DB::Exception::Exception(PreformattedMessage&&, int) @ 0x000000000772fe1c
2. DB::Exception::Exception<>(int, FormatStringHelperImpl<>) @ 0x0000000007746c34
3. DB::MergeTreeDataWriter::splitBlockIntoParts(DB::Block&&, unsigned long, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::Context const>, std::shared_ptr<DB::AsyncInsertInfo>) @ 0x0000000010c8af10
4. DB::SharedMergeTreeSinkImpl<true>::consume(DB::Chunk&) @ 0x0000000010f623b0
5. DB::SinkToStorage::onConsume(DB::Chunk) @ 0x0000000011539a98
6. void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::ExceptionKeepingTransform::work()::$_1, void ()>>(std::__function::__policy_storage const*) @ 0x000000001148cf9c
7. DB::runStep(std::function<void ()>, DB::ThreadStatus*, std::atomic<unsigned long>*) @ 0x000000001148cc58
8. DB::ExceptionKeepingTransform::work() @ 0x000000001148c444
9. DB::ExecutionThreadContext::executeTask() @ 0x000000001125b410
10. DB::PipelineExecutor::executeStepImpl(unsigned long, std::atomic<bool>*) @ 0x0000000011251194
11. DB::PipelineExecutor::execute(unsigned long, bool) @ 0x000000001125084c
12. DB::CompletedPipelineExecutor::execute() @ 0x000000001124f2f8
13. DB::AsynchronousInsertQueue::processData(DB::AsynchronousInsertQueue::InsertQuery, std::unique_ptr<DB::AsynchronousInsertQueue::InsertData, std::default_delete<DB::AsynchronousInsertQueue::InsertData>>, std::shared_ptr<DB::Context const>, DB::AsynchronousInsertQueue::QueueShardFlushTimeHistory&) @ 0x000000000f8bf2c4
14. void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::AsynchronousInsertQueue::scheduleDataProcessingJob(DB::AsynchronousInsertQueue::InsertQuery const&, std::unique_ptr<DB::AsynchronousInsertQueue::InsertData, std::default_delete<DB::AsynchronousInsertQueue::InsertData>>, std::shared_ptr<DB::Context const>, unsigned long)::$_0, void ()>>(std::__function::__policy_storage const*) @ 0x000000000f8c6884
15. ThreadPoolImpl<ThreadFromGlobalPoolImpl<false, true>>::worker(std::__list_iterator<ThreadFromGlobalPoolImpl<false, true>, void*>) @ 0x000000000c4ae95c
16. void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<false, true>::ThreadFromGlobalPoolImpl<void ThreadPoolImpl<ThreadFromGlobalPoolImpl<false, true>>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>(void&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x000000000c4b23b0
17. void* std::__thread_proxy[abi:v15007]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, void ThreadPoolImpl<std::thread>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>>(void*) @ 0x000000000c4b11cc
18. ? @ 0x000000000007d5c8
19. ? @ 0x00000000000e5edc
'.

@arthurpassos arthurpassos mentioned this pull request Sep 2, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LOGICAL_ERROR: Unexpected error for async deduplicated insert, please check error logs.

7 participants

@hanfei1991 @robot-ch-test-poll4 @arthurpassos @CurtizJ @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-2