Skip to content

Fix 03221_s3_imds_decent_timeout#68627

Merged
vdimir merged 3 commits intomasterfrom
vdimir/fix_03221_s3_imds_decent_timeout
Sep 20, 2024
Merged

Fix 03221_s3_imds_decent_timeout#68627
vdimir merged 3 commits intomasterfrom
vdimir/fix_03221_s3_imds_decent_timeout

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Aug 20, 2024

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Close #68579

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@vdimir vdimir added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 20, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Aug 20, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 308da20 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexkats alexkats self-assigned this Aug 20, 2024
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Aug 22, 2024 •
edited
Loading

Mergeable Check — failed: Stateless tests flaky check (asan)
Stateless tests flaky check (asan) — fail: 0, passed: 0, skipped: 2
Details

no-asan 🤷‍♂️

ClickHouse/tests/queries/0_stateless/03221_s3_imds_decent_timeout.sh

Line 2 in 3640ac8

# Tags: no-fasttest, no-asan, no-msan, no-tsan

@vdimir vdimir mentioned this pull request Aug 23, 2024
Merged
21 tasks
@Avogar Avogar mentioned this pull request Sep 1, 2024
Closed
@vdimir vdimir enabled auto-merge September 20, 2024 08:46
@vdimir vdimir added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit b12a367 Sep 20, 2024
@vdimir vdimir deleted the vdimir/fix_03221_s3_imds_decent_timeout branch September 20, 2024 10:15
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

+1 more reviewer

@alexkats alexkats alexkats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexkats alexkats

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test 03221_s3_imds_decent_timeout is flaky

5 participants

@vdimir @robot-ch-test-poll4 @alexkats @alexey-milovidov @robot-ch-test-poll