Skip to content

Skipping index cache#68553

Closed
rschu1ze wants to merge 4 commits intoClickHouse:masterfrom
rschu1ze:skipping-index-cache
Closed

Skipping index cache#68553
rschu1ze wants to merge 4 commits intoClickHouse:masterfrom
rschu1ze:skipping-index-cache

Conversation

@rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Aug 19, 2024

The original PR got stuck, refreshing it. Kudos to @al13n321

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added an in-memory cache for deserialized skipping index granules. This should make repeated queries that use skipping indexes faster. The size of the new cache is controlled by server settings skipping_index_cache_size and skipping_index_cache_max_entries. The original motivation for the cache were vector similarity indexes which became a lot faster now.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@rschu1ze rschu1ze added the do not test disable testing on pull request label Aug 19, 2024
@rschu1ze rschu1ze marked this pull request as draft August 19, 2024 15:30
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 19, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Aug 19, 2024

This is an automated comment for commit 8b2de11 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@rschu1ze rschu1ze force-pushed the skipping-index-cache branch from 2dc70e0 to 06719dc Compare September 24, 2024 13:36
@rschu1ze rschu1ze changed the title (wip, not review-able) Skipping index cache Skipping index cache Sep 24, 2024
@rschu1ze rschu1ze marked this pull request as ready for review September 24, 2024 14:55
@rschu1ze rschu1ze mentioned this pull request Sep 24, 2024
@rschu1ze rschu1ze force-pushed the skipping-index-cache branch from 5d833f9 to 9770095 Compare September 25, 2024 12:57
@robot-clickhouse robot-clickhouse added pr-feature Pull request with new product feature and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Sep 25, 2024
@rschu1ze
Copy link
Member Author

This PR got stuck in CI limbo. I'll posted the same PR here.

@rschu1ze rschu1ze closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not test disable testing on pull request pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants