Skip to content

Fix output of clickhouse-test in case of tests timeouts#68487

Merged
alesapin merged 2 commits intoClickHouse:masterfrom
azat:tests/capture-kill-output
Aug 28, 2024
Merged

Fix output of clickhouse-test in case of tests timeouts#68487
alesapin merged 2 commits intoClickHouse:masterfrom
azat:tests/capture-kill-output

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 16, 2024 •
edited
Loading

After #67737 the output will be broken, since in case of timeout it will print to stdout.

Let's just capture it and add it to stderr.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Follow-up for: #67737

@azat azat mentioned this pull request Aug 16, 2024
Merged
@azat
Fix output of clickhouse-test in case of tests timeouts
a66db7a 
After ClickHouse#67737 the output
will be broken, since in case of timeout it will print to stdout.

Let's just capture it and add it to stderr.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the tests/capture-kill-output branch from 880b38a to a66db7a Compare August 16, 2024 22:20
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 16, 2024
@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 16, 2024
@nickitat nickitat self-assigned this Aug 16, 2024
@nickitat
Copy link
Copy Markdown
Member

nickitat commented Aug 16, 2024

is there maybe an easy way to test this?

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 16, 2024

There are no tests for clickhouse-test, but I've tested it manually it works

@nickitat
Copy link
Copy Markdown
Member

nickitat commented Aug 16, 2024

ok.

@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Aug 16, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 3d40f70 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 18, 2024

Stateful tests (msan) — Invalid check_status.tsv

According to logs looks like spot instances issue

@alesapin alesapin added this pull request to the merge queue Aug 28, 2024
@alesapin alesapin self-assigned this Aug 28, 2024
Merged via the queue into ClickHouse:master with commit d8bf6bf Aug 28, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 28, 2024
@azat azat deleted the tests/capture-kill-output branch August 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@alesapin alesapin

@nickitat nickitat

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@azat @nickitat @robot-ch-test-poll3 @alesapin @robot-clickhouse @robot-clickhouse-ci-1