Add aggregate functions distinctDynamicTypes/distinctJSONPaths/distinctJSONPathsAndTypes by Avogar · Pull Request #68463 · ClickHouse/ClickHouse

Avogar · 2024-08-16T17:50:51Z

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add aggregate functions distinctDynamicTypes/distinctJSONPaths/distinctJSONPathsAndTypes for better introspection of JSON column type content

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

Allow: All Required Checks
Allow: Stateless tests
Allow: Stateful tests
Allow: Integration Tests
Allow: Performance tests
Allow: All Builds
Allow: batch 1, 2 for multi-batch jobs
Allow: batch 3, 4, 5, 6 for multi-batch jobs

Exclude: Style check
Exclude: Fast test
Exclude: All with ASAN
Exclude: All with TSAN, MSAN, UBSAN, Coverage
Exclude: All with aarch64, release, debug

Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
Exclude: AST fuzzers

…ctJSONPathsAndTypes

robot-ch-test-poll1 · 2024-08-16T17:56:41Z

This is an automated comment for commit ed2da41 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

…c-json-distinct-aggregate-functions

src/AggregateFunctions/AggregateFunctionDistinctDynamicTypes.cpp

…c-json-distinct-aggregate-functions

src/AggregateFunctions/AggregateFunctionDistinctDynamicTypes.cpp

src/Columns/ColumnDynamic.cpp

src/Columns/ColumnDynamic.h

src/AggregateFunctions/AggregateFunctionDistinctJSONPaths.cpp

tests/queries/0_stateless/03227_distinct_dynamic_types_json_paths.sql

src/AggregateFunctions/AggregateFunctionDistinctJSONPaths.cpp

Co-authored-by: János Benjamin Antal <[email protected]>

Avogar · 2024-08-29T11:13:35Z

Stateless tests (asan) [2/2] — Job failed, exit code: 210. Server died, fail: 14, passed: 2213, skipped: 33

#67606

…c-json-distinct-aggregate-functions

nakulogale · 2024-09-23T05:38:55Z

Hello,
I was trying to add an index to my JSON data type using distinctJSONPaths(json).
Table definition is

CREATE TABLE test
(
    `ingest_timestamp` DateTime64(3) CODEC(Delta(8), ZSTD(1)),
    `fields` Map(LowCardinality(String), String) CODEC(ZSTD(1)),
    `json` JSON, 
    INDEX idx_log_fields_key mapKeys(fields) TYPE bloom_filter(0.01) GRANULARITY 1,
    INDEX idx_log_fields_value mapValues(fields) TYPE bloom_filter(0.01) GRANULARITY 1,
    INDEX idx_text lower(text) TYPE tokenbf_v1(32768, 3, 0) GRANULARITY 1
)
ENGINE = MergeTree
PARTITION BY toDate(ingest_timestamp)
ORDER BY ( toUnixTimestamp64Milli(ingest_timestamp))
SETTINGS index_granularity = 8192, ttl_only_drop_parts = 1

Trying to add it so,
alter table test add index idx_json_paths distinctJSONPaths(json) TYPE bloom_filter(0.01) GRANULARITY 1;

Exception Trace:
`

2024.09.23 11:00:41.951108 [ 8781811 ] {query_id} executeQuery: (from [::1]:59855) alter table test add index idx_json_paths distinctJSONPaths(json) TYPE bloom_filter(0.01) GRANULARITY 1; (stage: Complete)
2024.09.23 11:00:41.951858 [ 8781811 ] {query_id} executeQuery: Code: 184. DB::Exception: Aggregate function distinctJSONPaths(json) is found in wrong place in query: While processing distinctJSONPaths(json). (ILLEGAL_AGGREGATION) (version 24.9.1.3018 (official build)) (from [::1]:59855) (in query: alter table test add index idx_json_paths distinctJSONPaths(json) TYPE bloom_filter(0.01) GRANULARITY 1;), Stack trace (when copying this message, always include the lines below):

Poco::Exception::Exception(String const&, int) @ 0x000000011258513d

DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000010b6aa95f

DB::Exception::Exception(PreformattedMessage&&, int) @ 0x0000000106acb034

DB::Exception::Exception<String, String>(int, FormatStringHelperImpl<std::type_identity::type, std::type_identity::type>, String&&, String&&) @ 0x0000000106acc66f

DB::GetAggregatesMatcher::visit(DB::ASTFunction const&, std::shared_ptrDB::IAST const&, DB::GetAggregatesMatcher::Data&) @ 0x000000010f5d4564

DB::InDepthNodeVisitor<DB::GetAggregatesMatcher, true, false, std::shared_ptrDB::IAST const>::doVisit(std::shared_ptrDB::IAST const&) @ 0x000000010f5d41cd

void DB::InDepthNodeVisitor<DB::GetAggregatesMatcher, true, false, std::shared_ptrDB::IAST const>::visitChildren(std::shared_ptrDB::IAST const&) @ 0x000000010f5d4839

DB::TreeRewriter::analyze(std::shared_ptrDB::IAST&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IStorage const>, std::shared_ptrDB::StorageSnapshot const&, bool, bool, bool, bool) const @ 0x000000010f9df059

DB::IndexDescription::getIndexFromAST(std::shared_ptrDB::IAST const&, DB::ColumnsDescription const&, std::shared_ptr<DB::Context const>) @ 0x0000000110224551

DB::AlterCommand::apply(DB::StorageInMemoryMetadata&, std::shared_ptr<DB::Context const>) const @ 0x00000001101dbeff

DB::AlterCommands::apply(DB::StorageInMemoryMetadata&, std::shared_ptr<DB::Context const>) const @ 0x00000001101e0241

DB::MergeTreeData::checkAlterIsPossible(DB::AlterCommands const&, std::shared_ptr<DB::Context const>) const @ 0x000000011073bfb4

DB::InterpreterAlterQuery::executeToTable(DB::ASTAlterQuery const&) @ 0x000000010f625542

DB::InterpreterAlterQuery::execute() @ 0x000000010f6236b1

DB::executeQueryImpl(char const*, char const*, std::shared_ptrDB::Context, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) @ 0x000000010fa3a8e8

DB::executeQuery(String const&, std::shared_ptrDB::Context, DB::QueryFlags, DB::QueryProcessingStage::Enum) @ 0x000000010fa370b8

DB::TCPHandler::runImpl() @ 0x0000000110c696cc

DB::TCPHandler::run() @ 0x0000000110c81b1c

Poco::Net::TCPServerConnection::start() @ 0x0000000112636e6c

Poco::Net::TCPServerDispatcher::run() @ 0x00000001126373de

Poco::PooledThread::run() @ 0x00000001125e1292

Poco::ThreadImpl::runnableEntry(void*) @ 0x00000001125dea41

_pthread_start @ 0x00007ff81af8918b

thread_start @ 0x00007ff81af84ae3

Elapsed: 0.002 sec.

Received exception from server (version 24.9.1):
Code: 184. DB::Exception: Received from DB::Exception: Aggregate function distinctJSONPaths(json) is found in wrong place in query: While processing distinctJSONPaths(json). (ILLEGAL_AGGREGATION)

`

Is there something fundamentally wrong the way I am using the aggregate 'distinctJSONPaths' function?
Is this an expected error?

I wish to create a similar index as created for the fields value.

Avogar · 2024-09-23T10:09:03Z

Is there something fundamentally wrong the way I am using the aggregate 'distinctJSONPaths' function?
Is this an expected error?

Yes, it's expected. You cannot use aggregate functions in the INDEX expressions. You can use usual functions. For JSON you can use function JSONAllPaths that returns the list of paths stored in each row

nakulogale · 2024-09-23T11:46:57Z

Is there something fundamentally wrong the way I am using the aggregate 'distinctJSONPaths' function?
Is this an expected error?

Yes, it's expected. You cannot use aggregate functions in the INDEX expressions. You can use usual functions. For JSON you can use function JSONAllPaths that returns the list of paths stored in each row

Thank you, JSONAllPaths worked.

nakulogale · 2024-09-25T08:38:43Z

Is there any function which can extract Values from a JSON/ string containing JSON ?
Something similar to 'JSONExtractKeys' function, say JSONExtractValues().
In continuation to the quoted scenario, I wish to create an index on both, JSON paths and the values.

Hello, I was trying to add an index to my JSON data type using distinctJSONPaths(json). Table definition is
CREATE TABLE test
(
    `ingest_timestamp` DateTime64(3) CODEC(Delta(8), ZSTD(1)),
    `fields` Map(LowCardinality(String), String) CODEC(ZSTD(1)),
    `json` JSON, 
    INDEX idx_log_fields_key mapKeys(fields) TYPE bloom_filter(0.01) GRANULARITY 1,
    INDEX idx_log_fields_value mapValues(fields) TYPE bloom_filter(0.01) GRANULARITY 1,
    INDEX idx_text lower(text) TYPE tokenbf_v1(32768, 3, 0) GRANULARITY 1
)
ENGINE = MergeTree
PARTITION BY toDate(ingest_timestamp)
ORDER BY ( toUnixTimestamp64Milli(ingest_timestamp))
SETTINGS index_granularity = 8192, ttl_only_drop_parts = 1 
Trying to add it so, alter table test add index idx_json_paths distinctJSONPaths(json) TYPE bloom_filter(0.01) GRANULARITY 1;

Exception Trace: `

2024.09.23 11:00:41.951108 [ 8781811 ] {query_id} executeQuery: (from [::1]:59855) alter table test add index idx_json_paths distinctJSONPaths(json) TYPE bloom_filter(0.01) GRANULARITY 1; (stage: Complete)
2024.09.23 11:00:41.951858 [ 8781811 ] {query_id} executeQuery: Code: 184. DB::Exception: Aggregate function distinctJSONPaths(json) is found in wrong place in query: While processing distinctJSONPaths(json). (ILLEGAL_AGGREGATION) (version 24.9.1.3018 (official build)) (from [::1]:59855) (in query: alter table test add index idx_json_paths distinctJSONPaths(json) TYPE bloom_filter(0.01) GRANULARITY 1;), Stack trace (when copying this message, always include the lines below):

Poco::Exception::Exception(String const&, int) @ 0x000000011258513d

DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000010b6aa95f

DB::Exception::Exception(PreformattedMessage&&, int) @ 0x0000000106acb034

DB::Exception::Exception<String, String>(int, FormatStringHelperImpl<std::type_identity::type, std::type_identity::type>, String&&, String&&) @ 0x0000000106acc66f

DB::GetAggregatesMatcher::visit(DB::ASTFunction const&, std::shared_ptrDB::IAST const&, DB::GetAggregatesMatcher::Data&) @ 0x000000010f5d4564

DB::InDepthNodeVisitor<DB::GetAggregatesMatcher, true, false, std::shared_ptrDB::IAST const>::doVisit(std::shared_ptrDB::IAST const&) @ 0x000000010f5d41cd

void DB::InDepthNodeVisitor<DB::GetAggregatesMatcher, true, false, std::shared_ptrDB::IAST const>::visitChildren(std::shared_ptrDB::IAST const&) @ 0x000000010f5d4839

DB::TreeRewriter::analyze(std::shared_ptrDB::IAST&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IStorage const>, std::shared_ptrDB::StorageSnapshot const&, bool, bool, bool, bool) const @ 0x000000010f9df059

DB::IndexDescription::getIndexFromAST(std::shared_ptrDB::IAST const&, DB::ColumnsDescription const&, std::shared_ptr<DB::Context const>) @ 0x0000000110224551

DB::AlterCommand::apply(DB::StorageInMemoryMetadata&, std::shared_ptr<DB::Context const>) const @ 0x00000001101dbeff

DB::AlterCommands::apply(DB::StorageInMemoryMetadata&, std::shared_ptr<DB::Context const>) const @ 0x00000001101e0241

DB::MergeTreeData::checkAlterIsPossible(DB::AlterCommands const&, std::shared_ptr<DB::Context const>) const @ 0x000000011073bfb4

DB::InterpreterAlterQuery::executeToTable(DB::ASTAlterQuery const&) @ 0x000000010f625542

DB::InterpreterAlterQuery::execute() @ 0x000000010f6236b1

DB::executeQueryImpl(char const*, char const*, std::shared_ptrDB::Context, DB::QueryFlags, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) @ 0x000000010fa3a8e8

DB::executeQuery(String const&, std::shared_ptrDB::Context, DB::QueryFlags, DB::QueryProcessingStage::Enum) @ 0x000000010fa370b8

DB::TCPHandler::runImpl() @ 0x0000000110c696cc

DB::TCPHandler::run() @ 0x0000000110c81b1c

Poco::Net::TCPServerConnection::start() @ 0x0000000112636e6c

Poco::Net::TCPServerDispatcher::run() @ 0x00000001126373de

Poco::PooledThread::run() @ 0x00000001125e1292

Poco::ThreadImpl::runnableEntry(void*) @ 0x00000001125dea41

_pthread_start @ 0x00007ff81af8918b

thread_start @ 0x00007ff81af84ae3

Elapsed: 0.002 sec.
Received exception from server (version 24.9.1):
Code: 184. DB::Exception: Received from DB::Exception: Aggregate function distinctJSONPaths(json) is found in wrong place in query: While processing distinctJSONPaths(json). (ILLEGAL_AGGREGATION)

`

Is there something fundamentally wrong the way I am using the aggregate 'distinctJSONPaths' function? Is this an expected error?

I wish to create a similar index as created for the fields value.

Add aggregate functions distinctDynamicTypes/distinctJSONPaths/distin…

32f4b1f

…ctJSONPathsAndTypes

Avogar mentioned this pull request Aug 16, 2024

[Umbrella] JSON type improvements #68428

Open

56 tasks

Avogar added the v24.8-must-backport label Aug 16, 2024

robot-ch-test-poll4 added the pr-feature Pull request with new product feature label Aug 16, 2024

Better example

85a813b

Avogar and others added 4 commits August 16, 2024 18:01

Fix style, update tests

f21e982

Fix tidy build

b29d524

Merge branch 'master' of github.com:ClickHouse/ClickHouse into dynami…

4bf9197

…c-json-distinct-aggregate-functions

Update 03227_distinct_dynamic_types_json_paths.sql

41f6e06

alexey-milovidov reviewed Aug 17, 2024

View reviewed changes

src/AggregateFunctions/AggregateFunctionDistinctDynamicTypes.cpp Show resolved Hide resolved

Avogar and others added 5 commits August 18, 2024 20:35

Add check for loo large array size

9d183b8

Fix bad conflict resolution

0793585

Fix spaces

64bce7a

Change test

a2b08e9

Merge branch 'master' of github.com:ClickHouse/ClickHouse into dynami…

a5a451e

…c-json-distinct-aggregate-functions

PedroTadim reviewed Aug 20, 2024

View reviewed changes

src/AggregateFunctions/AggregateFunctionDistinctDynamicTypes.cpp Show resolved Hide resolved

Avogar removed the v24.8-must-backport label Aug 21, 2024

antaljanosbenjamin reviewed Aug 28, 2024

View reviewed changes

antaljanosbenjamin self-assigned this Aug 28, 2024

Avogar commented Aug 28, 2024

View reviewed changes

src/AggregateFunctions/AggregateFunctionDistinctJSONPaths.cpp Outdated Show resolved Hide resolved

Avogar and others added 2 commits August 28, 2024 16:51

Apply suggestions from code review

a1c9cc4

Co-authored-by: János Benjamin Antal <[email protected]>

Address review comments

0aba986

antaljanosbenjamin approved these changes Aug 28, 2024

View reviewed changes

Avogar and others added 3 commits August 29, 2024 13:14

Reduce test size

d533c24

Merge branch 'master' of github.com:ClickHouse/ClickHouse into dynami…

2287f28

…c-json-distinct-aggregate-functions

Merge branch 'master' of github.com:ClickHouse/ClickHouse into dynami…

ed2da41

…c-json-distinct-aggregate-functions

Avogar added this pull request to the merge queue Sep 3, 2024

Merged via the queue into ClickHouse:master with commit 17baa4f Sep 3, 2024

Avogar deleted the dynamic-json-distinct-aggregate-functions branch September 3, 2024 18:27

robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aggregate functions distinctDynamicTypes/distinctJSONPaths/distinctJSONPathsAndTypes#68463

Add aggregate functions distinctDynamicTypes/distinctJSONPaths/distinctJSONPathsAndTypes#68463
Avogar merged 16 commits intoClickHouse:masterfrom
Avogar:dynamic-json-distinct-aggregate-functions

Avogar commented Aug 16, 2024

Uh oh!

robot-ch-test-poll1 commented Aug 16, 2024 •

edited by robot-ch-test-poll

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Avogar commented Aug 29, 2024

Uh oh!

nakulogale commented Sep 23, 2024 •

edited

Loading

Uh oh!

Avogar commented Sep 23, 2024

Uh oh!

nakulogale commented Sep 23, 2024

Uh oh!

nakulogale commented Sep 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

Avogar commented Aug 16, 2024

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI Settings (Only check the boxes if you know what you are doing):

Uh oh!

robot-ch-test-poll1 commented Aug 16, 2024 • edited by robot-ch-test-poll Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Avogar commented Aug 29, 2024

Uh oh!

nakulogale commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Avogar commented Sep 23, 2024

Uh oh!

nakulogale commented Sep 23, 2024

Uh oh!

nakulogale commented Sep 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

robot-ch-test-poll1 commented Aug 16, 2024 •

edited by robot-ch-test-poll

Loading

nakulogale commented Sep 23, 2024 •

edited

Loading