Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE" by antaljanosbenjamin · Pull Request #68386 · ClickHouse/ClickHouse

antaljanosbenjamin · 2024-08-15T09:22:41Z

This is the most probably cause of a LOGICAL_ERROR in our integration test:

E           helpers.client.QueryRuntimeException: Client failed! Return code: 32, stderr: [instance] 2024.08.15 04:46:09.472095 [ 9 ] {f857c866-77a8-49f6-a7ae-a184488ebc4e} <Fatal> : Logical error: 'Context has expired'.
E           [instance] 2024.08.15 04:46:09.507243 [ 9 ] {f857c866-77a8-49f6-a7ae-a184488ebc4e} <Fatal> : Stack trace (when copying this message, always include the lines below):
E           
E           0. ./contrib/llvm-project/libcxx/include/exception:141: Poco::Exception::Exception(String const&, int) @ 0x000000003404dfd4
E           1. ./build_docker/./src/Common/Exception.cpp:111: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000001accdf09
E           2. DB::Exception::Exception(PreformattedMessage&&, int) @ 0x000000000aa10445
E           3. DB::Exception::Exception<>(int, FormatStringHelperImpl<>) @ 0x000000000aa4a4ae
E           4. DB::WithContextImpl<std::shared_ptr<DB::Context const>>::getContext() const @ 0x000000000aa562f8
E           5. ./src/Interpreters/Context.h:835: DB::PipelineExecutor::PipelineExecutor(std::shared_ptr<std::vector<std::shared_ptr<DB::IProcessor>, std::allocator<std::shared_ptr<DB::IProcessor>>>>&, std::shared_ptr<DB::QueryStatus>) @ 0x000000002d0b6fce
E           6. ./contrib/llvm-project/libcxx/include/__memory/construct_at.h:0: DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long) @ 0x000000002d0d8a47
E           7. ./build_docker/./src/Processors/Executors/PullingAsyncPipelineExecutor.cpp:138: DB::PullingAsyncPipelineExecutor::pull(DB::Block&, unsigned long) @ 0x000000002d0d9a3f
E           8. ./build_docker/./src/Server/TCPHandler.cpp:0: DB::TCPHandler::processOrdinaryQuery() @ 0x000000002cf175bb
E           9. ./build_docker/./src/Server/TCPHandler.cpp:0: DB::TCPHandler::runImpl() @ 0x000000002cf03b0b
E           10. ./build_docker/./src/Server/TCPHandler.cpp:2486: DB::TCPHandler::run() @ 0x000000002cf35ac0
E           11. ./build_docker/./base/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x000000003422b76f
E           12. ./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:48: Poco::Net::TCPServerDispatcher::run() @ 0x000000003422c357
E           13. ./build_docker/./base/poco/Foundation/src/ThreadPool.cpp:219: Poco::PooledThread::run() @ 0x000000003412ea6b
E           14. ./base/poco/Foundation/include/Poco/SharedPtr.h:231: Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000034128bc8
E           15. asan_thread_start(void*) @ 0x000000000a9c5059
E           16. ? @ 0x00007fdf9dc85ac3
E           17. ? @ 0x00007fdf9dd17850

cc @azat

…sync BACKUP/RESTORE"

robot-ch-test-poll1 · 2024-08-15T09:26:11Z

This is an automated comment for commit 3af8ba2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	❌ failure

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

antaljanosbenjamin · 2024-08-15T15:22:44Z

The build is for sure not broken by this PR:

Aug 15 13:35:24 [6301/10844] Linking CXX executable utils/self-extracting-executable/pre_compressor
...
Aug 15 13:48:11 [10843/10844] Stripping clickhouse binary
Aug 15 13:48:11 [10844/10844] cd /build/build_docker/programs/self-extracting && /usr/bin/cmake -E remove clickhouse clickhouse-stripped && /build/build_docker/native/utils/self-extracting-executable/pre_compressor --decompressor=/build/build_docker/utils/self-extracting-executable/decompressor clickhouse ../clickhouse && /build/build_docker/native/utils/self-extracting-executable/pre_compressor --decompressor=/build/build_docker/utils/self-extracting-executable/decompressor clickhouse-stripped ../clickhouse-stripped
Aug 15 13:48:11 FAILED: programs/self-extracting/CMakeFiles/self-extracting-server /build/build_docker/programs/self-extracting/CMakeFiles/self-extracting-server 
Aug 15 13:48:11 cd /build/build_docker/programs/self-extracting && /usr/bin/cmake -E remove clickhouse clickhouse-stripped && /build/build_docker/native/utils/self-extracting-executable/pre_compressor --decompressor=/build/build_docker/utils/self-extracting-executable/decompressor clickhouse ../clickhouse && /build/build_docker/native/utils/self-extracting-executable/pre_compressor --decompressor=/build/build_docker/utils/self-extracting-executable/decompressor clickhouse-stripped ../clickhouse-stripped
Aug 15 13:48:11 /bin/sh: 1: /build/build_docker/native/utils/self-extracting-executable/pre_compressor: not found

Forcing mergeable check manually.

…in system.processes for async BACKUP/RESTORE"

Backport #68386 to 24.8: Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE"

azat · 2024-08-19T08:35:11Z

The build is for sure not broken by this PR:

There was an error before that was implicitly ignored, should be fixed by #68267

@antaljanosbenjamin

…STORE (resubmit) Resubmitted version of the initial patch that: - fixes for expired context (and adds a test for it), by just capturing the original context as well instead of introducing QueryStatus::updateContext() - adds a test for the fix itself Resubmits: ClickHouse#68163 Reverts: ClickHouse#68386 Cc: @antaljanosbenjamin Signed-off-by: Azat Khuzhin <[email protected]> (cherry picked from commit 8a48b33)

@antaljanosbenjamin

…STORE (resubmit) Resubmitted version of the initial patch that: - fixes for expired context (and adds a test for it), by just capturing the original context as well instead of introducing QueryStatus::updateContext() - adds a test for the fix itself Resubmits: ClickHouse#68163 Reverts: ClickHouse#68386 Cc: @antaljanosbenjamin Signed-off-by: Azat Khuzhin <[email protected]> (cherry picked from commit 8a48b33)

@antaljanosbenjamin

…STORE (resubmit) Resubmitted version of the initial patch that: - fixes for expired context (and adds a test for it), by just capturing the original context as well instead of introducing QueryStatus::updateContext() - adds a test for the fix itself Resubmits: ClickHouse#68163 Reverts: ClickHouse#68386 Cc: @antaljanosbenjamin Signed-off-by: Azat Khuzhin <[email protected]> (cherry picked from commit 8a48b33)

Revert "[RFC] Fix settings/current_database in system.processes for a…

3af8ba2

…sync BACKUP/RESTORE"

robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 15, 2024

antaljanosbenjamin added this pull request to the merge queue Aug 15, 2024

antaljanosbenjamin added the v24.8-must-backport label Aug 15, 2024

Merged via the queue into master with commit 4ac90f0 Aug 15, 2024

antaljanosbenjamin deleted the revert-68163-backups-processes branch August 15, 2024 15:54

robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 15, 2024

robot-ch-test-poll4 mentioned this pull request Aug 15, 2024

Cherry pick #68386 to 24.8: Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE" #68415

Merged

robot-clickhouse added a commit that referenced this pull request Aug 15, 2024

Backport #68386 to 24.8: Revert "[RFC] Fix settings/current_database …

9740ab6

…in system.processes for async BACKUP/RESTORE"

robot-ch-test-poll4 mentioned this pull request Aug 15, 2024

Backport #68386 to 24.8: Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE" #68416

Merged

robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 15, 2024

robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Aug 15, 2024

robot-ch-test-poll3 added a commit that referenced this pull request Aug 15, 2024

Merge pull request #68416 from ClickHouse/backport/24.8/68386

f3a0fb0

Backport #68386 to 24.8: Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE"

antaljanosbenjamin mentioned this pull request Aug 20, 2024

Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) #68267

Merged

azat mentioned this pull request Oct 25, 2024

Fix settings/current_database in system.processes for async BACKUP/RESTORE (resubmit) #71061

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE"#68386

Revert "[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE"#68386
antaljanosbenjamin merged 1 commit intomasterfrom
revert-68163-backups-processes

antaljanosbenjamin commented Aug 15, 2024

Uh oh!

robot-ch-test-poll1 commented Aug 15, 2024 •

edited by robot-clickhouse-ci-2

Loading

Uh oh!

antaljanosbenjamin commented Aug 15, 2024

Uh oh!

azat commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

antaljanosbenjamin commented Aug 15, 2024

Uh oh!

robot-ch-test-poll1 commented Aug 15, 2024 • edited by robot-clickhouse-ci-2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antaljanosbenjamin commented Aug 15, 2024

Uh oh!

azat commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robot-ch-test-poll1 commented Aug 15, 2024 •

edited by robot-clickhouse-ci-2

Loading