Skip to content

[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE#68163

Merged
antaljanosbenjamin merged 1 commit intoClickHouse:masterfrom
azat:backups-processes
Aug 12, 2024
Merged

[RFC] Fix settings/current_database in system.processes for async BACKUP/RESTORE#68163
antaljanosbenjamin merged 1 commit intoClickHouse:masterfrom
azat:backups-processes

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 11, 2024 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix settings/current_database in system.processes for async BACKUP/RESTORE

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-improvement Pull request with some product improvements label Aug 11, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Aug 11, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 8a48b33 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin self-assigned this Aug 12, 2024
antaljanosbenjamin
antaljanosbenjamin reviewed Aug 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks okay. I don't see a reliable way to write a test for this as I have no idea how we could stretch the length of backup/restore, but you might have some ideas. Do you think you can add a reliable test in some way?

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 12, 2024

I don't see a reliable way to write a test for this as I have no idea how we could stretch the length of backup/restore, but you might have some ideas. Do you think you can add a reliable test in some way?

Yes, right now it is tricky.

max_backup_bandwidth could be used to throttle backup, but the problem is that you cannot KILL the backup in the middle of the copy now, so what I'm planning to do, is to finish #52092 and then, write a test (it possible to write a test even now, but it will be an integration test, which I don't like)

antaljanosbenjamin
antaljanosbenjamin approved these changes Aug 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am from my phone, will merge the PR once I get back in front my laptop (latest tomorrow).

@antaljanosbenjamin
Copy link
Copy Markdown
Member

antaljanosbenjamin commented Aug 12, 2024

The performance tests is very unlikely to be related, honestly I cannot imagine it is related.

@antaljanosbenjamin antaljanosbenjamin added this pull request to the merge queue Aug 12, 2024
Merged via the queue into ClickHouse:master with commit 6eb4a71 Aug 12, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 12, 2024
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Aug 15, 2024
Merged
@azat azat deleted the backups-processes branch August 19, 2024 08:36
azat added a commit to azat/ClickHouse that referenced this pull request Oct 25, 2024
@azat
Fix settings/current_database in system.processes for async BACKUP/RE…
bc1acdf 
…STORE (resubmit)

Resubmitted version of the initial patch that:
- fixes for expired context (and adds a test for it), by just capturing
  the original context as well instead of introducing QueryStatus::updateContext()
- adds a test for the fix itself

Resubmits: ClickHouse#68163
Reverts: ClickHouse#68386
Cc: @antaljanosbenjamin
Signed-off-by: Azat Khuzhin <[email protected]>
(cherry picked from commit 8a48b33)
@azat azat mentioned this pull request Oct 25, 2024
Closed
azat added a commit to azat/ClickHouse that referenced this pull request Oct 25, 2024
@azat
Fix settings/current_database in system.processes for async BACKUP/RE…
50ff95b 
…STORE (resubmit)

Resubmitted version of the initial patch that:
- fixes for expired context (and adds a test for it), by just capturing
  the original context as well instead of introducing QueryStatus::updateContext()
- adds a test for the fix itself

Resubmits: ClickHouse#68163
Reverts: ClickHouse#68386
Cc: @antaljanosbenjamin
Signed-off-by: Azat Khuzhin <[email protected]>
(cherry picked from commit 8a48b33)
azat added a commit to azat/ClickHouse that referenced this pull request Oct 25, 2024
@azat
Fix settings/current_database in system.processes for async BACKUP/RE…
1cf51c6 
…STORE (resubmit)

Resubmitted version of the initial patch that:
- fixes for expired context (and adds a test for it), by just capturing
  the original context as well instead of introducing QueryStatus::updateContext()
- adds a test for the fix itself

Resubmits: ClickHouse#68163
Reverts: ClickHouse#68386
Cc: @antaljanosbenjamin
Signed-off-by: Azat Khuzhin <[email protected]>
(cherry picked from commit 8a48b33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-ch-test-poll1 @antaljanosbenjamin @robot-ch-test-poll3 @robot-clickhouse-ci-2