Skip to content

Fix window view missing blocks due to slow flush to view#67983

Merged
Algunenano merged 7 commits intoClickHouse:masterfrom
Algunenano:flaky_win_view
Aug 27, 2024
Merged

Fix window view missing blocks due to slow flush to view#67983
Algunenano merged 7 commits intoClickHouse:masterfrom
Algunenano:flaky_win_view

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Aug 7, 2024 •
edited by kssenii
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix window view missing blocks due to slow flush to view

Reverts the recent changes making the tests no-parallel, which helped as it reduced the chance of the flush being slow (which leads to the block not being sent to the WATCH client)

Investigated based on https://s3.amazonaws.com/clickhouse-test-reports/67914/0cef18993604d80c85f9efc3d4bc6f5450995d66/stateless_tests_flaky_check__asan_.html. I changed the test to make it always fail without code changes (instead of being flaky)

Closes #53486.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Algunenano Algunenano requested a review from kssenii August 7, 2024 13:14
@Algunenano Algunenano changed the title Flaky win view Fix window view missing blocks due to slow flush to view Aug 7, 2024
This was referenced Aug 7, 2024
Open
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 7, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Aug 7, 2024 •
edited
Loading

This is an automated comment for commit e8d9fbd with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@kssenii kssenii self-assigned this Aug 7, 2024
@Algunenano Algunenano added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 7, 2024
@alexey-milovidov alexey-milovidov self-assigned this Aug 7, 2024
kssenii
kssenii reviewed Aug 7, 2024
View reviewed changes
src/Storages/WindowView/StorageWindowView.cpp
try
{
if (max_watermark >= timestamp_now)
if (max_watermark >= timestamp_start)
Copy link
Copy Markdown
Member

@kssenii kssenii Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 1099 also needs to be updated.

@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Aug 27, 2024

01114_database_atomic -> Fixed in #68930

@Algunenano Algunenano enabled auto-merge August 27, 2024 10:34
@Algunenano Algunenano added this pull request to the merge queue Aug 27, 2024
Merged via the queue into ClickHouse:master with commit e3ef11e Aug 27, 2024
@Algunenano Algunenano deleted the flaky_win_view branch August 27, 2024 11:06
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@kssenii kssenii kssenii approved these changes

Assignees

@alexey-milovidov alexey-milovidov

@kssenii kssenii

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test 01053_window_view_proc_hop_to_now is flaky

6 participants

@Algunenano @robot-ch-test-poll @alexey-milovidov @kssenii @robot-ch-test-poll2 @robot-ch-test-poll3