Skip to content

tests: fix 03002_part_log_rmt_fetch_merge_error flakiness#67960

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/03002_part_log_rmt_fetch__error
Aug 8, 2024
Merged

tests: fix 03002_part_log_rmt_fetch_merge_error flakiness#67960
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/03002_part_log_rmt_fetch__error

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 7, 2024

CI found 1:

--- /usr/share/clickhouse-test/queries/0_stateless/03002_part_log_rmt_fetch_merge_error.reference	2024-08-07 05:09:42.058643403 +0200
+++ /tmp/clickhouse-test/0_stateless/03002_part_log_rmt_fetch_merge_error.stdout	2024-08-07 05:54:45.514083455 +0200
@@ -6,5 +6,7 @@
 after
 rmt_master	NewPart	0	1
 rmt_master	MergeParts	0	1
+rmt_master	RemovePart	0	1
 rmt_slave	MergeParts	1	0
 rmt_slave	DownloadPart	0	2
+rmt_slave	RemovePart	0	1

MergeTree settings used in test: --ratio_of_defaults_for_sparse_serialization 1.0 --prefer_fetch_merged_part_size_threshold 3517855074 --vertical_merge_algorithm_min_rows_to_activate 1000000 --vertical_merge_algorithm_min_columns_to_activate 100 --allow_vertical_merges_from_compact_to_wide_parts 0 --min_merge_bytes_to_use_direct_io 10737418240 --index_granularity_bytes 7659983 --merge_max_block_size 17667 --index_granularity 48465 --min_bytes_for_wide_part 1073741824 --marks_compress_block_size 58048 --primary_key_compress_block_size 18342 --replace_long_file_name_to_hash 0 --max_file_name_length 36 --min_bytes_for_full_part_storage 536870912 --compact_parts_max_bytes_to_buffer 148846831 --compact_parts_max_granules_to_buffer 140 --compact_parts_merge_max_bytes_to_prefetch_part 4513530 --cache_populated_by_fetch 1 --concurrent_part_removal_threshold 8 --old_parts_lifetime 10

The reason is old_parts_lifetime=10

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 7, 2024
@azat azat mentioned this pull request Aug 7, 2024
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 7, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Aug 7, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 8542703 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@novikd novikd self-assigned this Aug 7, 2024
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 7, 2024

By some reason the tests timed out, but this test is not related to timeout since it had passed.

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 7, 2024

@fm4v and there are still no artifacts

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 7, 2024

One of the reason could be - gdb, should be fixed (or at least improved) in #66494

@azat azat mentioned this pull request Aug 7, 2024
Merged
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Aug 7, 2024

@azat, we apologize for our mistake, #67986
Please merge with master again.

@azat
tests: fix 03002_part_log_rmt_fetch_merge_error flakiness
8542703 
CI found [1]:

    --- /usr/share/clickhouse-test/queries/0_stateless/03002_part_log_rmt_fetch_merge_error.reference	2024-08-07 05:09:42.058643403 +0200
    +++ /tmp/clickhouse-test/0_stateless/03002_part_log_rmt_fetch_merge_error.stdout	2024-08-07 05:54:45.514083455 +0200
    @@ -6,5 +6,7 @@
     after
     rmt_master	NewPart	0	1
     rmt_master	MergeParts	0	1
    +rmt_master	RemovePart	0	1
     rmt_slave	MergeParts	1	0
     rmt_slave	DownloadPart	0	2
    +rmt_slave	RemovePart	0	1

    MergeTree settings used in test: --ratio_of_defaults_for_sparse_serialization 1.0 --prefer_fetch_merged_part_size_threshold 3517855074 --vertical_merge_algorithm_min_rows_to_activate 1000000 --vertical_merge_algorithm_min_columns_to_activate 100 --allow_vertical_merges_from_compact_to_wide_parts 0 --min_merge_bytes_to_use_direct_io 10737418240 --index_granularity_bytes 7659983 --merge_max_block_size 17667 --index_granularity 48465 --min_bytes_for_wide_part 1073741824 --marks_compress_block_size 58048 --primary_key_compress_block_size 18342 --replace_long_file_name_to_hash 0 --max_file_name_length 36 --min_bytes_for_full_part_storage 536870912 --compact_parts_max_bytes_to_buffer 148846831 --compact_parts_max_granules_to_buffer 140 --compact_parts_merge_max_bytes_to_prefetch_part 4513530 --cache_populated_by_fetch 1 --concurrent_part_removal_threshold 8 --old_parts_lifetime 10

The reason is old_parts_lifetime=10

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67511/881d57a7644057b586e4cdb95ebb8785d912d4c5/stateless_tests__msan__%5B3_4%5D.html

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the tests/03002_part_log_rmt_fetch__error branch from 284178b to 8542703 Compare August 7, 2024 21:06
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 7, 2024

OK. Done

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Aug 8, 2024
Merged via the queue into ClickHouse:master with commit d60cb9d Aug 8, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 8, 2024
@azat azat deleted the tests/03002_part_log_rmt_fetch__error branch August 8, 2024 05:15
@pufit pufit mentioned this pull request Aug 13, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@azat @robot-ch-test-poll1 @alexey-milovidov @novikd @robot-ch-test-poll @robot-ch-test-poll4