Skip to content

Scatter blocks in hash join without copying#67782

Merged
nickitat merged 74 commits intomasterfrom
better_parallel_hash2
Nov 17, 2024
Merged

Scatter blocks in hash join without copying#67782
nickitat merged 74 commits intomasterfrom
better_parallel_hash2

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Aug 4, 2024 •
edited
Loading

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Now we won't copy input blocks columns for join_algorithm='parallel_hash' when distribute them between threads for parallel processing.

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-performance Pull request with some performance improvements label Aug 4, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Aug 4, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit d0842ee with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir self-assigned this Aug 5, 2024
@nickitat nickitat force-pushed the better_parallel_hash2 branch from cc7cf8b to 101eeae Compare August 12, 2024 19:34
@rschu1ze rschu1ze mentioned this pull request Nov 4, 2024
Closed
nickitat
nickitat commented Nov 16, 2024
View reviewed changes
@nickitat nickitat marked this pull request as ready for review November 17, 2024 21:02
@nickitat nickitat added this pull request to the merge queue Nov 17, 2024
Merged via the queue into master with commit c198e1c Nov 17, 2024
@nickitat nickitat deleted the better_parallel_hash2 branch November 17, 2024 21:41
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 17, 2024
@vdimir vdimir mentioned this pull request Nov 20, 2024
Closed
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 27, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#67782
fb76c15
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 27, 2024
@baibaichen
Fix Benchmark Build due to ClickHouse/ClickHouse#67782
707aa05
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 28, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#67782
df35b9c
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 28, 2024
@baibaichen
Fix Benchmark Build due to ClickHouse/ClickHouse#67782
0e81721
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 28, 2024
@baibaichen
Fix Benchmark Build due to [Scatter blocks in hash join without copyi…
41adf1d 
…ng](ClickHouse/ClickHouse#67782)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 29, 2024
@baibaichen
Fix Benchmark Build due to [Scatter blocks in hash join without copyi…
a524f14 
…ng](ClickHouse/ClickHouse#67782)

(cherry picked from commit 8d566d6a8b8785e4072ffd6f774eb83b07ac3d8d)
baibaichen added a commit to apache/gluten that referenced this pull request Nov 30, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241129) (#8087)
b2706cb 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241129)

* Fix Build AND UT Due to [Added cache for primary index](ClickHouse/ClickHouse#72102)

* Fix Build and UT due to [no auto write buffer finalization in destructors](ClickHouse/ClickHouse#68800)

- Make LocalPartitionWriter::evictPartitions called, e.g. set(GlutenConfig.COLUMNAR_CH_SHUFFLE_SPILL_THRESHOLD.key, (1024*1024).toString)

* Fix Build due to [Save several minutes of build time](ClickHouse/ClickHouse#72046)

* Fix Benchmark Build due to [Scatter blocks in hash join without copying](ClickHouse/ClickHouse#67782)

(cherry picked from commit 8d566d6a8b8785e4072ffd6f774eb83b07ac3d8d)

* Fix Benchmark Build

* Fix endless loop due to ClickHouse/ClickHouse#70598

* [Refactor #8100] using CHConf.setCHConfig()

* fix style

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels

pr-performance Pull request with some performance improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickitat @robot-clickhouse-ci-2 @vdimir @robot-clickhouse-ci-1