Skip to content

Try to fix RabbitMQ test failures#67743

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
azat:tests/test_storage_rabbitmq
Aug 4, 2024
Merged

Try to fix RabbitMQ test failures#67743
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
azat:tests/test_storage_rabbitmq

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 4, 2024

Changes

  • use version without management (slightly faster)
  • increase startup timeout

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Refs: #45160

azat added 3 commits August 4, 2024 09:04
@azat
Use RabbitMQ without management in tests (attempt to improve startup)
59e5a09 
Sometimes startup can take ~90 seconds [1]:

    2024-08-03 23:11:38.756067+00:00 [info] <0.9.0> Time to start RabbitMQ: 94651980 us

Unlike normally ~10 [2]:

    2024-08-04 00:33:07.016137+00:00 [info] <0.9.0> Time to start RabbitMQ: 10082489 us

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/67737/b4e3bbcb82158bea4f5db1d9f5c28cfb741d1d51/integration_tests__asan__old_analyzer__[4_6].html
  [2]: https://s3.amazonaws.com/clickhouse-test-reports/66671/2f00c962711e13ca00af324366421fe4593b4ce6/integration_tests__asan__old_analyzer__[4_6].html

I've tried locally, the difference is very small, 3135665 us
(+management) vs (2740747 us), but still something, and who knows how it
works under pressure.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat
tests: increase timeout for RabbitMQ startup
264be9c 
Signed-off-by: Azat Khuzhin <[email protected]>
@azat
tests: detailed errors for RabbitMQ startup
dc527b6 
Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 4, 2024
@azat azat mentioned this pull request Aug 4, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 4, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Aug 4, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit dc527b6 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@kssenii kssenii self-assigned this Aug 4, 2024
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 4, 2024

Cloud fork sync (only for ClickHouse Inc. employees) — tests failed

@kssenii any clue?

@kssenii
Copy link
Copy Markdown
Member

kssenii commented Aug 4, 2024

Cloud fork sync (only for ClickHouse Inc. employees) — tests failed

@kssenii any clue?

one unrelated test failed...

@alexey-milovidov alexey-milovidov merged commit 6f9d78d into ClickHouse:master Aug 4, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 4, 2024
@azat azat deleted the tests/test_storage_rabbitmq branch August 4, 2024 19:47
@kssenii kssenii mentioned this pull request Aug 5, 2024
Closed
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Aug 6, 2024

Not fixed: https://s3.amazonaws.com/clickhouse-test-reports/0/8af682f7483f3651957200d0a9ef8bbb9b7a0141/integration_tests__tsan__[4_6].html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@azat @robot-ch-test-poll4 @kssenii @alexey-milovidov @robot-ch-test-poll3 @robot-clickhouse-ci-1