02481_async_insert_race_long.sh flakiness fixes#67650
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Aug 2, 2024
Merged
02481_async_insert_race_long.sh flakiness fixes#67650alexey-milovidov merged 1 commit intoClickHouse:masterfrom
02481_async_insert_race_long.sh flakiness fixes#67650alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
1. Make the test truly asynchronous. The setting `--async_insert_max_data_size 1` leads to data being flushed synchronously for all inserts in this test. This triggers part creation and extra resource consumption. 2. Do not run the `--wait_for_async_insert` query as a background process with a fixed (50ms) sleep time. If the actual execution time is longer than the anticipated delay time, it may lead to excessive process creation.
Contributor
|
This is an automated comment for commit 572831f with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
pufit
approved these changes
Aug 2, 2024
This was referenced Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the test truly asynchronous. The setting
--async_insert_max_data_size 1leads to data being flushed synchronously for all inserts in this test. This triggers part creation and extra resource consumption.Do not run the
--wait_for_async_insertquery as a background process with a fixed (50ms) sleep time after spawning.If the execution time is longer than the anticipated delay, it may lead to excessive process creation.
To reproduce the
"Connection reset by peer while reading from socket"error [0], increase the number of background threads, e.g.:[0] https://s3.amazonaws.com/clickhouse-test-reports/60377/bc9c462155bed43eeb72415660917900ee4e7b58/stateless_tests__tsan__s3_storage__%5B2_4%5D.html
https://github.com/ClickHouse/clickhouse-private/issues/13101
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):