Skip to content

02481_async_insert_race_long.sh flakiness fixes#67650

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
jkartseva:async-insert-race-long-fixes
Aug 2, 2024
Merged

02481_async_insert_race_long.sh flakiness fixes#67650
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
jkartseva:async-insert-race-long-fixes

Conversation

@jkartseva
Copy link
Copy Markdown
Member

@jkartseva jkartseva commented Aug 2, 2024

  1. Make the test truly asynchronous. The setting --async_insert_max_data_size 1 leads to data being flushed synchronously for all inserts in this test. This triggers part creation and extra resource consumption.

  2. Do not run the --wait_for_async_insert query as a background process with a fixed (50ms) sleep time after spawning.
    If the execution time is longer than the anticipated delay, it may lead to excessive process creation.

To reproduce the "Connection reset by peer while reading from socket" error [0], increase the number of background threads, e.g.:

--- a/tests/queries/0_stateless/02481_async_insert_race_long.sh
+++ b/tests/queries/0_stateless/02481_async_insert_race_long.sh
@@ -51,7 +51,7 @@ export -f select1

 TIMEOUT=10

-for _ in {1..3}; do
+for _ in {1..32}; do
     insert1 $TIMEOUT &
     insert2 $TIMEOUT &
     insert3 $TIMEOUT &
diff --git a/utils/check-style/check-large-objects.sh b/utils/check-style/check-large-objects.sh

[0] https://s3.amazonaws.com/clickhouse-test-reports/60377/bc9c462155bed43eeb72415660917900ee4e7b58/stateless_tests__tsan__s3_storage__%5B2_4%5D.html

https://github.com/ClickHouse/clickhouse-private/issues/13101

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

1. Make the test truly asynchronous.
The setting `--async_insert_max_data_size 1` leads to data
being flushed synchronously for all inserts in this test.
This triggers part creation and extra resource consumption.

2. Do not run the `--wait_for_async_insert` query as a background process
with a fixed (50ms) sleep time.
If the actual execution time is longer than the anticipated delay
time, it may lead to excessive process creation.
@jkartseva jkartseva added can be tested Allows running workflows for external contributors 🍃 green ci 🌿 Fixing flaky tests in CI labels Aug 2, 2024
@jkartseva jkartseva linked an issue Aug 2, 2024 that may be closed by this pull request
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-feature Pull request with new product feature label Aug 2, 2024
@jkartseva jkartseva removed the pr-feature Pull request with new product feature label Aug 2, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Aug 2, 2024

This is an automated comment for commit 572831f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@pufit pufit self-assigned this Aug 2, 2024
@jkartseva jkartseva added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@alexey-milovidov alexey-milovidov merged commit 8b00531 into ClickHouse:master Aug 2, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors 🍃 green ci 🌿 Fixing flaky tests in CI pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functional tests for async inserts are flaky (2)

5 participants