Skip to content

Revert #61750 "Improve JSONEachRow reading by ignoring the keys case"#67484

Merged
al13n321 merged 5 commits intomasterfrom
nojs
Aug 6, 2024
Merged

Revert #61750 "Improve JSONEachRow reading by ignoring the keys case"#67484
al13n321 merged 5 commits intomasterfrom
nojs

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Jul 30, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

#61750 - the implementation is not efficient enough and not general enough.

al13n321 added 2 commits July 30, 2024 21:13
@al13n321
Revert "Rename bad setting"
51212a4 
This reverts commit eb4ec09.
@al13n321
Revert "Merge pull request #61750 from KevinyhZou/improve_json_each_r…
07291cb 
…ow_ignore_key_case"

This reverts commit 3229cb5, reversing
changes made to f838c25.
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 30, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Jul 30, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 4e8bd06 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@nikitamikhaylov nikitamikhaylov self-assigned this Jul 30, 2024
@al13n321 al13n321 enabled auto-merge August 5, 2024 23:12
@al13n321 al13n321 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into master with commit dc776af Aug 6, 2024
@al13n321 al13n321 deleted the nojs branch August 6, 2024 09:05
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 6, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Aug 8, 2024
@baibaichen
Revert "[GLUTEN-6262][CH]Json input format ignore key case apache#6263"…
3d2ed3b 
… due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750

This reverts commit 2be6c86.
baibaichen added a commit to Kyligence/gluten that referenced this pull request Aug 8, 2024
@baibaichen
Revert "[GLUTEN-6262][CH]Json input format ignore key case apache#6263"…
2591a60 
… due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750

This reverts commit 2be6c86.
@baibaichen baibaichen mentioned this pull request Aug 8, 2024
Open
baibaichen added a commit to apache/gluten that referenced this pull request Aug 8, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240808) (#6755)
5410c83 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240808)

* Fix build due to ClickHouse/ClickHouse#66279

* Revert "[GLUTEN-6262][CH]Json input format ignore key case #6263" due to ClickHouse/ClickHouse#67484 revert ClickHouse/ClickHouse#61750

This reverts commit 2be6c86.

* fix gtest due to #6722

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@al13n321 @robot-clickhouse @nikitamikhaylov @robot-ch-test-poll4 @robot-ch-test-poll3