Skip to content

Fix flaky 00180_no_seek_avoiding_when_reading_from_cache#67236

Merged
yakov-olkhovskiy merged 1 commit intomasterfrom
fix-test-00180-filesystem-cache
Jul 27, 2024
Merged

Fix flaky 00180_no_seek_avoiding_when_reading_from_cache#67236
yakov-olkhovskiy merged 1 commit intomasterfrom
fix-test-00180-filesystem-cache

Conversation

@yakov-olkhovskiy
Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy commented Jul 26, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

closes #66683

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 26, 2024
@alexey-milovidov alexey-milovidov self-assigned this Jul 26, 2024
@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 26, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 26, 2024 •
edited
Loading

This is an automated comment for commit 0f4274a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@yakov-olkhovskiy
Copy link
Copy Markdown
Member Author

yakov-olkhovskiy commented Jul 27, 2024

Data-race reported:
#67270

@yakov-olkhovskiy yakov-olkhovskiy added this pull request to the merge queue Jul 27, 2024
Merged via the queue into master with commit 610ecdd Jul 27, 2024
@yakov-olkhovskiy yakov-olkhovskiy deleted the fix-test-00180-filesystem-cache branch July 27, 2024 07:35
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 27, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 30, 2024

Not fixed: https://s3.amazonaws.com/clickhouse-test-reports/67417/4eb2bf3419d7f3640ec8b77bc0ca80a138cd2584/stateful_tests__tsan_.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test 00180_no_seek_avoiding_when_reading_from_cache is flaky

4 participants

@yakov-olkhovskiy @robot-ch-test-poll @alexey-milovidov @robot-clickhouse