Skip to content

Fix stacktrace cache#67173

Merged
antonio2368 merged 4 commits intomasterfrom
fix-stacktrace-cache
Jul 27, 2024
Merged

Fix stacktrace cache#67173
antonio2368 merged 4 commits intomasterfrom
fix-stacktrace-cache

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented Jul 26, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Stacktrace cache was never used because of a stupid bug I created in #67016

Lessons learned: if a test almost never failed but did in your PR it is most likely related.

Fix #67169

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@antonio2368 antonio2368 mentioned this pull request Jul 26, 2024
Merged
18 tasks
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 26, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jul 26, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 503dc25 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antonio2368 antonio2368 force-pushed the fix-stacktrace-cache branch from e00480c to 0c5c23e Compare July 26, 2024 08:49
This was referenced Jul 26, 2024
Merged
Merged
@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 26, 2024
@antonio2368 antonio2368 force-pushed the fix-stacktrace-cache branch from 2189528 to 0bd0568 Compare July 26, 2024 14:22
@antonio2368 antonio2368 force-pushed the fix-stacktrace-cache branch from 0bd0568 to 503dc25 Compare July 26, 2024 14:23
@davenger davenger mentioned this pull request Jul 26, 2024
Closed
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 26, 2024
Merged
@antonio2368 antonio2368 added this pull request to the merge queue Jul 27, 2024
Merged via the queue into master with commit f6990bb Jul 27, 2024
@antonio2368 antonio2368 deleted the fix-stacktrace-cache branch July 27, 2024 07:35
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 27, 2024
@pamarcos pamarcos mentioned this pull request Jul 29, 2024
Merged
yakov-olkhovskiy
yakov-olkhovskiy reviewed Feb 14, 2025
View reviewed changes
src/Common/Exception.h
Comment on lines +74 to +90
static thread_local bool can_use_thread_frame_pointers;
/// Because of unknown order of static destructor calls,
/// thread_frame_pointers can already be uninitialized when a different destructor generates an exception.
/// To prevent such scenarios, a wrapper class is created and a function that will return empty vector
/// if its destructor is already called
using ThreadFramePointersBase = std::vector<StackTrace::FramePointers>;
struct ThreadFramePointers
{
ThreadFramePointers();
~ThreadFramePointers();

ThreadFramePointersBase frame_pointers;
};

static ThreadFramePointersBase getThreadFramePointers();
static void setThreadFramePointers(ThreadFramePointersBase frame_pointers);

Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently this trick doesn't work - can_use_thread_frame_pointers is always false when we are accessing thread_frame_pointers...

This was referenced Feb 15, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yakov-olkhovskiy yakov-olkhovskiy yakov-olkhovskiy left review comments

Assignees

No one assigned

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test 00705_drop_create_merge_tree has failed

6 participants

@antonio2368 @robot-ch-test-poll1 @yakov-olkhovskiy @alexey-milovidov @robot-clickhouse @robot-ch-test-poll4