Skip to content

Uncomment accidentally commented out code in QueryProfiler#67152

Merged
al13n321 merged 2 commits intomasterfrom
ohno
Jul 26, 2024
Merged

Uncomment accidentally commented out code in QueryProfiler#67152
al13n321 merged 2 commits intomasterfrom
ohno

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Jul 25, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Oops.

Is there a simple way to prevent such mistakes? A way to run CI without creating a PR? Or to put something in the code that makes PR unmergeable but still runs tests?

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 25, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jul 25, 2024

This is an automated comment for commit 992a276 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@evillique evillique self-assigned this Jul 25, 2024
@al13n321 al13n321 mentioned this pull request Jul 25, 2024
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment also write_trace_iteration

@al13n321 al13n321 enabled auto-merge July 25, 2024 21:25
@al13n321 al13n321 added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit fc45850 Jul 26, 2024
@al13n321 al13n321 deleted the ohno branch July 26, 2024 00:44
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 26, 2024
yokofly added a commit to timeplus-io/proton that referenced this pull request Jan 22, 2026
…d update)

* ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV

Fix SIGSEGV due to CPU/Real profiler

* ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash

Fix crash in libunwind while interpreting debug info

* ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7

* ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch

Revert libunwind patch

* ClickHouse/ClickHouse#66977 from ClickHouse/uwo

Apply libunwind fix

* ClickHouse/ClickHouse#68312 from ClickHouse/muslwind

Apply libunwind changes needed for musl

* ClickHouse/ClickHouse#76107 from ClickHouse/owo

Apply libunwind fix for DwarfFDECache

* ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo

Revert "Apply libunwind fix for DwarfFDECache"

* ClickHouse/ClickHouse#76178 from ClickHouse/unw

Apply libunwind fix for DwarfFDECache, attempt 2

* Update libunwind to aec8e58

* ClickHouse/ClickHouse#67152 from ClickHouse/ohno

Uncomment accidentally commented out code in QueryProfiler

* ClickHouse/ClickHouse#64058  aarch64 sigaltstack size fix

* ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes

---------

Co-authored-by: Nikita Mikhaylov <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: Michael Kolupaev <[email protected]>
Co-authored-by: Antonio Andelic <[email protected]>
Co-authored-by: Max Kainov <[email protected]>
yokofly added a commit to timeplus-io/proton that referenced this pull request Jan 23, 2026
…d update) (#11324)

* ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV

Fix SIGSEGV due to CPU/Real profiler

* ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash

Fix crash in libunwind while interpreting debug info

* ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7

* ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch

Revert libunwind patch

* ClickHouse/ClickHouse#66977 from ClickHouse/uwo

Apply libunwind fix

* ClickHouse/ClickHouse#68312 from ClickHouse/muslwind

Apply libunwind changes needed for musl

* ClickHouse/ClickHouse#76107 from ClickHouse/owo

Apply libunwind fix for DwarfFDECache

* ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo

Revert "Apply libunwind fix for DwarfFDECache"

* ClickHouse/ClickHouse#76178 from ClickHouse/unw

Apply libunwind fix for DwarfFDECache, attempt 2

* Update libunwind to aec8e58

* ClickHouse/ClickHouse#67152 from ClickHouse/ohno

Uncomment accidentally commented out code in QueryProfiler

* ClickHouse/ClickHouse#64058  aarch64 sigaltstack size fix

* ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes

---------

Co-authored-by: Nikita Mikhaylov <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: Michael Kolupaev <[email protected]>
Co-authored-by: Antonio Andelic <[email protected]>
Co-authored-by: Max Kainov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants