Attempt to fix flakiness of some window view tests#67130
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Jul 26, 2024
Merged
Attempt to fix flakiness of some window view tests#67130alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
hanfei1991
approved these changes
Jul 25, 2024
Contributor
|
This is an automated comment for commit 4b505ba with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
robot-clickhouse
added a commit
that referenced
this pull request
Jul 26, 2024
rschu1ze
added a commit
that referenced
this pull request
Jul 26, 2024
Backport #67130 to 24.7: Attempt to fix flakiness of some window view tests
robot-clickhouse-ci-2
added
the
pr-backports-created-cloud
robot-clickhouse-ci-1
added
the
pr-backports-created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66887 (maybe)
This was frustrating. The test should work if the feature works the way the docs describe it ... I studied for many hours the log output of sporadically failing runs of 01075_window_view_proc_tumble_to_now_populate to understand why the view does not always update the destination table but the logs don't give a clue. The failure did not reproduce locally. Then had an idea yesterday (#67097) but turned out it was misguided. Studied the logs more today, still no clue.
I am now following in the footsteps of #44438 and hope this will stabilize the tests.
Changelog category (leave one):