Skip to content

Reintroduce 03002_part_log_rmt_fetch_*_error tests without flakiness and less time#67113

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:tests/part_log_rmt_fetch_errors
Aug 6, 2024
Merged

Reintroduce 03002_part_log_rmt_fetch_*_error tests without flakiness and less time#67113
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
azat:tests/part_log_rmt_fetch_errors

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 25, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Reverts: #66823 (cc @alexey-milovidov )

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 25, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jul 25, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 50aebcf with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat azat mentioned this pull request Jul 25, 2024
Closed
1 task
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 4, 2024

Stateless tests (release) — Some queries hung, fail: 1, passed: 6807, skipped: 6

2024.07.26 02:33:23.424663 [ 890 ] {} <Warning> Application: Child process was stopped by signal 19.

This is SIGSTOP, and it is likely a gdb issue, #66494

azat added 2 commits August 5, 2024 20:25
@azat
Revert "Remove bad tests @azat" (reverts ClickHouse#66823)
3593f74 
This reverts commit 0c2c027.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat
Rewrite 03002_part_log_rmt_fetch_*_error tests from sql to sh with re…
50aebcf 
…tries

Except for this patch should fix the flakiness of this test it also
reduces the execution time from 15.4s to 3.3s (5x!)

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat force-pushed the tests/part_log_rmt_fetch_errors branch from e42eeb9 to 50aebcf Compare August 5, 2024 18:26
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 6, 2024

CI is green

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Aug 6, 2024
@alexey-milovidov alexey-milovidov self-assigned this Aug 6, 2024
Merged via the queue into ClickHouse:master with commit 9a297b3 Aug 6, 2024
@azat azat deleted the tests/part_log_rmt_fetch_errors branch August 6, 2024 15:27
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 6, 2024
@qoega
Copy link
Copy Markdown
Member

qoega commented Aug 7, 2024

It is still flaky:
https://s3.amazonaws.com/clickhouse-test-reports/67511/881d57a7644057b586e4cdb95ebb8785d912d4c5/stateless_tests__msan__%5B3_4%5D.html

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 7, 2024

Will be fixed in #67960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-ch-test-poll4 @qoega @alexey-milovidov @robot-ch-test-poll3