Skip to content

A more precise way of tracking flushing time in 01246_buffer_flush#67099

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/01246_buffer_flush
Jul 26, 2024
Merged

A more precise way of tracking flushing time in 01246_buffer_flush#67099
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/01246_buffer_flush

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 25, 2024 •
edited by alexey-milovidov
Loading

Right now there are couple of issues with the test:

  • it does not take into account INSERT time

  • it does not take into account SELECT time, which can be significant from time to time, for instance here 1 it takes 3.3 seconds (and due to tsan build it is not possible to find out why)

    2024.07.23 20:52:18.238844 [ 13045 ] {d903650b-ab87-44f3-b7c3-4145e02f1301} <Debug> executeQuery: (from [::1]:39430) (comment: 01246_buffer_flush.sh) select count() from data_01256; (stage: Complete)
2024.07.23 20:52:21.588183 [ 13045 ] {d903650b-ab87-44f3-b7c3-4145e02f1301} <Debug> TCPHandler: Processed in 3.354887498 sec.

Anyway all of this can be fixed by using QueryStart-insert into data table time.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@azat
The most precise way of tracking flushing time in 01246_buffer_flush
60f529f 
Right now there are couple of issues with the test:

- it does not takes into account INSERT time
- it does not takes into account SELECT time, which can be significant
  from time to time, for instance here [1] it takes 3.3 seconds (and due
  to tsan build it is not possible to find out why)

      2024.07.23 20:52:18.238844 [ 13045 ] {d903650b-ab87-44f3-b7c3-4145e02f1301} <Debug> executeQuery: (from [::1]:39430) (comment: 01246_buffer_flush.sh) select count() from data_01256; (stage: Complete)
      2024.07.23 20:52:21.588183 [ 13045 ] {d903650b-ab87-44f3-b7c3-4145e02f1301} <Debug> TCPHandler: Processed in 3.354887498 sec.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/66934/919005c4f70b044ecd9cc1bbce5dc5e276e11929/stateless_tests__tsan__s3_storage__[4_4].html

Anyway all of this can be fixed by using QueryStart-insert into data
table time.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat mentioned this pull request Jul 25, 2024
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 25, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 25, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 60f529f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 25, 2024
@alexey-milovidov alexey-milovidov changed the title The most precise way of tracking flushing time in 01246_buffer_flush A more precise way of tracking flushing time in 01246_buffer_flush Jul 26, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jul 26, 2024
Merged via the queue into ClickHouse:master with commit a9c0e97 Jul 26, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 26, 2024
@azat azat deleted the tests/01246_buffer_flush branch July 26, 2024 19:22
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 28, 2024

Not fixed: https://s3.amazonaws.com/clickhouse-test-reports/0/796b1196efa1ea590421bd87e68e08a47634c89a/stateless_tests__ubsan__[2_2].html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-ch-test-poll @alexey-milovidov @robot-clickhouse @robot-clickhouse-ci-2