[CI Party] Fix flaky window view tests#67097
Closed
rschu1ze wants to merge 1 commit intoClickHouse:masterfrom
Closed
[CI Party] Fix flaky window view tests#67097rschu1ze wants to merge 1 commit intoClickHouse:masterfrom
rschu1ze wants to merge 1 commit intoClickHouse:masterfrom
Conversation
robot-ch-test-poll2
added
the
pr-not-for-changelog
rschu1ze
force-pushed
the
unflake-win-view-tests
branch
from
41fe980 to
0358755
Compare
antonio2368
reviewed
Jul 25, 2024
| "--allow_experimental_analyzer=0" | ||
| ) | ||
|
|
||
| db="$(random_str 10)" |
Member
There was a problem hiding this comment.
you can use CLICKHOUSE_TEST_UNIQUE_NAME
Algunenano
reviewed
Jul 25, 2024
| DROP TABLE IF EXISTS mt; | ||
| DROP TABLE IF EXISTS dst; | ||
| DROP TABLE IF EXISTS wv; | ||
| DROP DATABASE IF EXISTS ${db}; |
Member
There was a problem hiding this comment.
This should be automatic. Each test runs under $CLICKHOUSE_DATABASE. If we need to manually create it it's either because we are doing extremely special (which we aren't in this case), a bad test or a bug.
Contributor
|
This is an automated comment for commit 0358755 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
This was referenced Jul 25, 2024
Member
Author
|
Closed in favor of #67130 Also see #65583 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65583
The issue ^^ is technically only about
01075_window_view_proc_tumble_to_now_populatebut almost all window view tests are affected, so this PR fixes them all.Changelog category (leave one):