Skip to content

Fix 2680 flasky#67078

Merged
alesapin merged 1 commit intoClickHouse:masterfrom
jsc0218:fix2680
Jul 26, 2024
Merged

Fix 2680 flasky#67078
alesapin merged 1 commit intoClickHouse:masterfrom
jsc0218:fix2680

Conversation

@jsc0218
Copy link
Copy Markdown
Contributor

@jsc0218 jsc0218 commented Jul 24, 2024

try to fix this, looks like it is related to this thread.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@jsc0218 jsc0218 added flaky test flaky test found by CI can be tested Allows running workflows for external contributors and removed flaky test flaky test found by CI labels Jul 24, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 24, 2024
@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jul 24, 2024 •
edited
Loading

This is an automated comment for commit 687c99e with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

alesapin
alesapin reviewed Jul 25, 2024
View reviewed changes
tests/queries/0_stateless/02680_mysql_ast_logical_err.sql
SELECT count() FROM mysql(
mysql('127.0.0.1:9004', currentDatabase(), 'foo', 'default', '', SETTINGS connection_pool_size = 1),
'127.0.0.1:9004', currentDatabase(), 'foo', '', '',
SETTINGS connect_timeout = 100, connection_wait_timeout = 100, read_write_timeout = 300); -- { serverError UNKNOWN_FUNCTION, UNSUPPORTED_METHOD }
Copy link
Copy Markdown
Member

@alesapin alesapin Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like read_write_timeout is default 300: https://github.com/ClickHouse/ClickHouse/blob/master/src/Core/Settings.h#L717

Copy link
Copy Markdown
Member

@alesapin alesapin Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connect_timeout is default 10 seconds, but looks like test fails for different reason, because in total it took 7 seconds to fail: https://s3.amazonaws.com/clickhouse-test-reports/63216/3bfe71f9232de8a98cc7fe026627d9f68d938a10/stateless_tests__debug__[1_5].html

Copy link
Copy Markdown
Member

@alesapin alesapin Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connection_wait_timeout is default 5. Maybe it's a reason, but it looks suspicious. Have you checked the logs that MySQL connections pool is saturated?

Copy link
Copy Markdown
Contributor Author

@jsc0218 jsc0218 Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alesapin I think the root cause is explained here due to misuse of millisecond and second. Through that fix, this issue should be fixed as well. A similar issue is 2479 with the same stacktrace. The issue doesn't appear after the fix. Setting parameters is just in case of any future change.

@alesapin alesapin added this pull request to the merge queue Jul 26, 2024
Merged via the queue into ClickHouse:master with commit 21fa963 Jul 26, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 26, 2024
@jsc0218 jsc0218 deleted the fix2680 branch July 26, 2024 13:42
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 26, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jul 26, 2024
@robot-clickhouse
Backport #67078 to 24.7: Fix 2680 flasky
e67b26d
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 26, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Jul 26, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 26, 2024
jsc0218 added a commit that referenced this pull request Jul 27, 2024
@jsc0218
Merge pull request #67222 from ClickHouse/backport/24.7/67078
8ed7ca4 
Backport #67078 to 24.7: Fix 2680 flasky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin left review comments

Assignees

@alesapin alesapin

Labels

can be tested Allows running workflows for external contributors 🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test 02680_mysql_ast_logical_err

6 participants

@jsc0218 @robot-clickhouse-ci-2 @alesapin @alexey-milovidov @robot-ch-test-poll4 @robot-ch-test-poll3