Try to fix exception logging in destructors of static objects#67016
Merged
antonio2368 merged 4 commits intomasterfrom Jul 25, 2024
Merged
Try to fix exception logging in destructors of static objects#67016antonio2368 merged 4 commits intomasterfrom
antonio2368 merged 4 commits intomasterfrom
Conversation
Contributor
|
This is an automated comment for commit 67567fc with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
18 tasks
kssenii
approved these changes
Jul 24, 2024
This was referenced Jul 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Logging exceptions in destructor of static objects can access freed objects because we don't know in which order are the objects destroyed (e.g.
StackTraceCachewe use for generating stacktraces).To prevent this I added couple of safeguards where:
BaseDaemonobject is destroyedI also noticed that we don't handle exceptions for
LazyPipeFDs::closecorrectly in some places so I added a failpoint and a test.Fix #67001
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):