Skip to content

Fix storage Buffer over Distributed#67015

Merged
vdimir merged 5 commits intomasterfrom
vdimir/block_stucture_mismatch_62486
Aug 7, 2024
Merged

Fix storage Buffer over Distributed#67015
vdimir merged 5 commits intomasterfrom
vdimir/block_stucture_mismatch_62486

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jul 24, 2024 •
edited
Loading

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix logical errors with storage Buffer used with distributed destination table. It's a backward incompatible change: queries using Buffer with a distributed destination table may stop working if the table appears more than once in the query (e.g., in a self-join).

Close #62486

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 24, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 24, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 4e8d11c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir changed the title Check argument types in DataTypeAggregateFunction ctor Fixing storage Buffer over Distributed Jul 24, 2024
@vdimir vdimir added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
@vdimir vdimir changed the title Fixing storage Buffer over Distributed Fix storage Buffer over Distributed Jul 26, 2024
@vdimir vdimir marked this pull request as ready for review July 26, 2024 16:24
@robot-clickhouse robot-clickhouse added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jul 26, 2024
@vdimir vdimir force-pushed the vdimir/block_stucture_mismatch_62486 branch from 42fb591 to 645ed95 Compare July 26, 2024 16:30
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 27, 2024

Needs #67170

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 27, 2024

Good, but let's also label it as a backward incompatible change.

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jul 29, 2024 •
edited
Loading

Good, but let's also label it as a backward incompatible change.

@alexey-milovidov

I made some effort to ensure that queries that work in the current version or with the old analyzer remain runnable. Cases that are forbidden in this PR were broken and threw exceptions like UNSUPPORTED_METHOD or UNKNOWN_IDENTIFIER:

https://fiddle.clickhouse.com/44135093-aed9-498b-9fd3-0fab2f5406e6

However, we can mark it as (potentially) backward incompatible in case there are some missed cases.

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jul 30, 2024

Stateless tests (msan) [2/4] — fail: 1, passed: 1719, skipped: 22 Details

Fixed in #67169

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-backward-incompatible Pull request with backwards incompatible changes and removed pr-bugfix Pull request with bugfix, not backported by default labels Jul 30, 2024
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Aug 1, 2024 •
edited
Loading

AST fuzzer (debug) — Logical error: 'Expected single dictionary argument for function.'. Details

SELECT intDivOrZero(intDivOrZero(toLowCardinality(-128), toLowCardinality(-1)) = 0, materialize(toLowCardinality(4))) FROM realtimebuff__fuzz_188 GROUP BY materialize(toLowCardinality(-127)), intDivOrZero(0, 0) = toLowCardinality(toLowCardinality(0)) WITH TOTALS ORDER BY ALL DESC NULLS FIRST;

May be related (in maser it's THERE_IS_NO_COLUMN, allowing such query revealed logical error), investigating ...

UPD: after merging master issue is fixed, added testcase

Stateless tests (release, old analyzer, s3, DatabaseReplicated) [2/4] — fail: 1, passed: 1708, skipped: 35 Details

#67599

@vdimir vdimir force-pushed the vdimir/block_stucture_mismatch_62486 branch from 10a9613 to 4e8d11c Compare August 5, 2024 16:47
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Aug 6, 2024

Stateless tests (tsan, s3 storage) [2/4] — fail: 1, passed: 1710, skipped: 42 Details

01168_mutations_isolation #67842

@vdimir vdimir added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit 53c4c51 Aug 7, 2024
@vdimir vdimir deleted the vdimir/block_stucture_mismatch_62486 branch August 7, 2024 10:23
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block structure mismatch in UnionStep

6 participants

@vdimir @robot-ch-test-poll @alexey-milovidov @robot-clickhouse @robot-clickhouse-ci-1 @robot-clickhouse-ci-2