Skip to content

Un-flake test_runtime_configurable_cache_size#66934

Merged
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:issue-66887
Jul 24, 2024
Merged

Un-flake test_runtime_configurable_cache_size#66934
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:issue-66887

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Jul 23, 2024

Fixes #66887

This PR simplifies the test such that it can no longer be affected by timing.

For simplicity, the check against system.asynchronous_metrics is replaced by a check against system.query_cache. A new stateless test to check asynchronous metrics was added instead.

Kudos to @antonio2368: #66887 (comment)

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze mentioned this pull request Jul 23, 2024
Closed
@antonio2368 antonio2368 self-assigned this Jul 23, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 23, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Jul 23, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 919005c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Jul 24, 2024

ClickHouse Integration Tests (aarch64) [3/6]: #67002
ClickHouse Stateless Tests (tsan, S3 Storage) [4/4]: #66188

@rschu1ze rschu1ze added this pull request to the merge queue Jul 24, 2024
Merged via the queue into ClickHouse:master with commit 68a0b28 Jul 24, 2024
@rschu1ze rschu1ze deleted the issue-66887 branch July 24, 2024 08:26
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 24, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 26, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jul 26, 2024
@robot-clickhouse
Backport #66934 to 24.7: Un-flake test_runtime_configurable_cache_size
53304bf
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 26, 2024
Merged
rschu1ze added a commit that referenced this pull request Jul 26, 2024
@rschu1ze
Merge pull request #67207 from ClickHouse/backport/24.7/66934
403ee89 
Backport #66934 to 24.7: Un-flake test_runtime_configurable_cache_size
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label Jul 26, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test_runtime_configurable_cache_size

7 participants

@rschu1ze @robot-clickhouse @antonio2368 @robot-ch-test-poll @robot-ch-test-poll2 @robot-clickhouse-ci-1 @robot-clickhouse-ci-2