Skip to content

[CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)#66898

Merged
alesapin merged 4 commits intomasterfrom
better_handling_of_errors
Jul 24, 2024
Merged

[CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)#66898
alesapin merged 4 commits intomasterfrom
better_handling_of_errors

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jul 22, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

In rare cases ClickHouse could consider parts as broken because of some unexpected projections on disk. Now it's fixed.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@alesapin alesapin added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 22, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label Jul 22, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 22, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 342efff with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

tavplubix
tavplubix approved these changes Jul 22, 2024
View reviewed changes
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 23, 2024

Timeouts look weirds :(

@alexey-milovidov alexey-milovidov mentioned this pull request Jul 24, 2024
Merged
18 tasks
@alesapin alesapin added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
@alesapin alesapin changed the title Better processing of broken parts and their projections [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forver) Jul 24, 2024
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 24, 2024

00159_parallel_formatting_http #67010

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 24, 2024

03036_dynamic_read_subcolumns #67011

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 24, 2024

This PR already addressing flaky test, so it's valid to merge with triaged unrelated test failures.
Bugfix validation will not be fixed -- to hard to add a test for it.

@alesapin alesapin added this pull request to the merge queue Jul 24, 2024
Merged via the queue into master with commit da2e347 Jul 24, 2024
@alesapin alesapin deleted the better_handling_of_errors branch July 24, 2024 10:07
@alexey-milovidov alexey-milovidov changed the title [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forver) [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever) Jul 24, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 24, 2024
This was referenced Jul 24, 2024
Closed
Merged
Merged
Merged
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 24, 2024
@robot-clickhouse
Backport #66898 to 24.7: [CI Fest] Better processing of broken parts …
a299dad 
…and their projections (fixes rare cases of lost forever)
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jul 24, 2024
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Jul 24, 2024
@robot-ch-test-poll2
Merge pull request #67026 from ClickHouse/backport/24.7/66898
7518a54 
Backport #66898 to 24.7: [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created-cloud deprecated label, NOOP label Jul 24, 2024
robot-clickhouse added a commit that referenced this pull request Jul 30, 2024
@robot-clickhouse
Backport #66898 to 24.3: [CI Fest] Better processing of broken parts …
2bc9a6d 
…and their projections (fixes rare cases of lost forever)
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 30, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jul 30, 2024
@robot-clickhouse
Backport #66898 to 24.4: [CI Fest] Better processing of broken parts …
f30c2a7 
…and their projections (fixes rare cases of lost forever)
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 30, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jul 30, 2024
@robot-clickhouse
Backport #66898 to 24.5: [CI Fest] Better processing of broken parts …
8d7f38d 
…and their projections (fixes rare cases of lost forever)
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 30, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jul 30, 2024
@robot-clickhouse
Backport #66898 to 24.6: [CI Fest] Better processing of broken parts …
0b3898c 
…and their projections (fixes rare cases of lost forever)
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 30, 2024
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 30, 2024
robot-ch-test-poll3 added a commit that referenced this pull request Jul 31, 2024
@robot-ch-test-poll3
Merge pull request #67482 from ClickHouse/backport/24.6/66898
f6370f7 
Backport #66898 to 24.6: [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)
robot-ch-test-poll3 added a commit that referenced this pull request Jul 31, 2024
@robot-ch-test-poll3
Merge pull request #67481 from ClickHouse/backport/24.5/66898
5f1ad84 
Backport #66898 to 24.5: [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)
tavplubix added a commit that referenced this pull request Sep 3, 2024
@tavplubix
Merge pull request #67479 from ClickHouse/backport/24.3/66898
fee3ca8 
Backport #66898 to 24.3: [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)
tavplubix added a commit that referenced this pull request Sep 3, 2024
@tavplubix
Merge pull request #67480 from ClickHouse/backport/24.4/66898
24a4836 
Backport #66898 to 24.4: [CI Fest] Better processing of broken parts and their projections (fixes rare cases of lost forever)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alesapin @robot-ch-test-poll @tavplubix @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-clickhouse-ci-1