Skip to content

Split test 03038_nested_dynamic_merges to avoid timeouts#66863

Merged
Avogar merged 3 commits intoClickHouse:masterfrom
Avogar:split-test-03038
Jul 23, 2024
Merged

Split test 03038_nested_dynamic_merges to avoid timeouts#66863
Avogar merged 3 commits intoClickHouse:masterfrom
Avogar:split-test-03038

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jul 22, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 22, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 22, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 023276b with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Jul 22, 2024 •
edited
Loading

The timeouts are happening because of small values of random settings like max_block_size and index_granularity. But I really don't want to use fixed values for these settings in this test because the randomization of these settings in this test can find real issues (and there were already a few found like this). If splitting won't help, I would disable this test in debug/sanitizer builds to avoid timeputs but keep random settings in release build

@alexey-milovidov alexey-milovidov self-assigned this Jul 23, 2024
@Avogar Avogar added this pull request to the merge queue Jul 23, 2024
Merged via the queue into ClickHouse:master with commit 6981e62 Jul 23, 2024
@Avogar Avogar deleted the split-test-03038 branch July 23, 2024 11:06
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 23, 2024
@Avogar Avogar mentioned this pull request Jul 23, 2024
Closed
@vitlibar
Copy link
Copy Markdown
Member

vitlibar commented Jul 25, 2024

Test 03038_nested_dynamic_merges_wide_vertical can still fail because of the timeout:
https://s3.amazonaws.com/clickhouse-test-reports/66881/2e25808e586d46baf52029d626d02fdcc6ff53d2/stateless_tests__tsan__s3_storage__[1_4].html

@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Jul 25, 2024

There was follow-up PR: #66981
Let's see if it will help

@vitlibar vitlibar mentioned this pull request Jul 25, 2024
Merged
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 27, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Avogar @robot-ch-test-poll @vitlibar @alexey-milovidov @robot-clickhouse-ci-1 @robot-clickhouse-ci-2