Skip to content

Revert libunwind patch#66850

Merged
antonio2368 merged 2 commits intomasterfrom
revert-libunwind-patch
Jul 23, 2024
Merged

Revert libunwind patch#66850
antonio2368 merged 2 commits intomasterfrom
revert-libunwind-patch

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented Jul 22, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This patch ClickHouse/libunwind#27 causes segfault inside libunwind when signal handler is called from inside the libunwind.

Interesting that reverting this PR also fixes the issue ClickHouse/libunwind#25 (cc @azat)

So I suspect the issue is something simple but reverting for now as a quick fix.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@antonio2368 antonio2368 mentioned this pull request Jul 22, 2024
Merged
19 tasks
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jul 22, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jul 22, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit f692bce with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano Algunenano self-assigned this Jul 22, 2024
@Algunenano Algunenano added the blocker This issue / pr blocks a new release label Jul 22, 2024
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Jul 22, 2024

We need this or revert #65509 completely as it's causing crashes -> https://s3.amazonaws.com/clickhouse-test-reports/0/846922aeae590d4c441404f1874a4ec4fad22022/stateless_tests__release_.html

Algunenano
Algunenano approved these changes Jul 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see. If not, let's revert the source PR and introduce it when patched fully

This was referenced Jul 22, 2024
Merged
Merged
@antonio2368 antonio2368 added this pull request to the merge queue Jul 23, 2024
Merged via the queue into master with commit b6b1a7a Jul 23, 2024
@antonio2368 antonio2368 deleted the revert-libunwind-patch branch July 23, 2024 10:30
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 23, 2024
yokofly added a commit to timeplus-io/proton that referenced this pull request Jan 22, 2026
@yokofly @nikitamikhaylov
@alexey-milovidov @al13n321 @antonio2368 @maxknv
Fix occasional QueryProfiler SIGSEGV during stack unwinding (libunwin…
786437e 
…d update)

* ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV

Fix SIGSEGV due to CPU/Real profiler

* ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash

Fix crash in libunwind while interpreting debug info

* ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7

* ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch

Revert libunwind patch

* ClickHouse/ClickHouse#66977 from ClickHouse/uwo

Apply libunwind fix

* ClickHouse/ClickHouse#68312 from ClickHouse/muslwind

Apply libunwind changes needed for musl

* ClickHouse/ClickHouse#76107 from ClickHouse/owo

Apply libunwind fix for DwarfFDECache

* ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo

Revert "Apply libunwind fix for DwarfFDECache"

* ClickHouse/ClickHouse#76178 from ClickHouse/unw

Apply libunwind fix for DwarfFDECache, attempt 2

* Update libunwind to aec8e58

* ClickHouse/ClickHouse#67152 from ClickHouse/ohno

Uncomment accidentally commented out code in QueryProfiler

* ClickHouse/ClickHouse#64058  aarch64 sigaltstack size fix

* ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes

---------

Co-authored-by: Nikita Mikhaylov <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: Michael Kolupaev <[email protected]>
Co-authored-by: Antonio Andelic <[email protected]>
Co-authored-by: Max Kainov <[email protected]>
yokofly added a commit to timeplus-io/proton that referenced this pull request Jan 23, 2026
@yokofly @nikitamikhaylov
@alexey-milovidov @al13n321 @antonio2368 @maxknv
Fix occasional QueryProfiler SIGSEGV during stack unwinding (libunwin…
83d1268 
…d update) (#11324)

* ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV

Fix SIGSEGV due to CPU/Real profiler

* ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash

Fix crash in libunwind while interpreting debug info

* ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7

* ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch

Revert libunwind patch

* ClickHouse/ClickHouse#66977 from ClickHouse/uwo

Apply libunwind fix

* ClickHouse/ClickHouse#68312 from ClickHouse/muslwind

Apply libunwind changes needed for musl

* ClickHouse/ClickHouse#76107 from ClickHouse/owo

Apply libunwind fix for DwarfFDECache

* ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo

Revert "Apply libunwind fix for DwarfFDECache"

* ClickHouse/ClickHouse#76178 from ClickHouse/unw

Apply libunwind fix for DwarfFDECache, attempt 2

* Update libunwind to aec8e58

* ClickHouse/ClickHouse#67152 from ClickHouse/ohno

Uncomment accidentally commented out code in QueryProfiler

* ClickHouse/ClickHouse#64058  aarch64 sigaltstack size fix

* ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes

---------

Co-authored-by: Nikita Mikhaylov <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: Michael Kolupaev <[email protected]>
Co-authored-by: Antonio Andelic <[email protected]>
Co-authored-by: Max Kainov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

@al13n321 al13n321 al13n321 approved these changes

Assignees

@Algunenano Algunenano

Labels

blocker This issue / pr blocks a new release pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@antonio2368 @robot-clickhouse-ci-1 @Algunenano @al13n321 @robot-ch-test-poll @robot-ch-test-poll2