Skip to content

Remove bad tests @azat#66823

Merged
github-merge-queue[bot] merged 1 commit intomasterfrom
remove-bad-tests-azat
Jul 22, 2024
Merged

Remove bad tests @azat#66823
github-merge-queue[bot] merged 1 commit intomasterfrom
remove-bad-tests-azat

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jul 21, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

These tests contain unconditional sleep as a synchronization, which is guaranteed to not work.
They also contain words about slavery.

These tests could be rewritten with sleep in a conditional loop; let @azat do it in another pull request.

Needed for #66737

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 21, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jul 21, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 0c2c027 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jul 21, 2024

We have to fix the timeout in the check with TSan + S3 storage.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jul 22, 2024

Data race in clickhouse-local.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jul 22, 2024

@azat Could you please rewrite these tests?

@alexey-milovidov alexey-milovidov mentioned this pull request Jul 22, 2024
Merged
18 tasks
@github-merge-queue github-merge-queue bot merged commit 5cb4114 into master Jul 22, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 22, 2024
@Algunenano Algunenano mentioned this pull request Jul 23, 2024
Closed
@Algunenano Algunenano self-assigned this Jul 23, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Jul 23, 2024
@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
This was referenced Jul 25, 2024
Merged
Closed
azat added a commit to azat/ClickHouse that referenced this pull request Aug 5, 2024
@azat
Revert "Remove bad tests @azat" (reverts ClickHouse#66823)
3593f74 
This reverts commit 0c2c027.

Signed-off-by: Azat Khuzhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Algunenano Algunenano

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexey-milovidov @robot-clickhouse-ci-1 @Algunenano @robot-ch-test-poll @robot-ch-test-poll1 @robot-clickhouse-ci-2