This ticket is involve multiple files, I will continue reviewing and working on my changes to ensure that it works as expected, feel free to review and point out mistakes I made!

This is an automated comment for commit 92ad740 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

@alexey-milovidov
Hi I just notice that the current Fast Check Cannot be passed, and error like

2024-07-26 00:28:45 Connection error, will retry:  [Errno 111] Connection refused
2024-07-26 00:28:56 Connection error, will retry:  [Errno 111] Connection refused

Can be seen, can you please take a look and provide me with some help on how to fix this one? Appreciate it!

It is a problem with your changes. Read the logs here: https://s3.amazonaws.com/clickhouse-test-reports/66791/b4511ab45e7c3e306052d5eeabdf15749b0b67d1/fast_test.html

It is a problem with your changes. Read the logs here: https://s3.amazonaws.com/clickhouse-test-reports/66791/b4511ab45e7c3e306052d5eeabdf15749b0b67d1/fast_test.html

@alexey-milovidov

Hi I read through the log you shared with me, and I noticed that it is the same as the link I checked previously: https://github.com/ClickHouse/ClickHouse/actions/runs/10101883167/job/27936478262?pr=66791
To ensure that I didn't miss anything important, I have carefully checked the log again, and I don't think I could find the error you mentioned...

Can you please share with me where the error is, or tell me which part of the log should I check? I will be really appreciate it!

The server does not start: https://s3.amazonaws.com/clickhouse-test-reports/66791/b4511ab45e7c3e306052d5eeabdf15749b0b67d1/fast_test/run.log

The server does not start: https://s3.amazonaws.com/clickhouse-test-reports/66791/b4511ab45e7c3e306052d5eeabdf15749b0b67d1/fast_test/run.log

@alexey-milovidov
Hi sorry for the confusion, my question here is what could be the possible cause of this issue? Or which part is responsible for the logic of starting the server? I was trying to restore my changes in ConnectionPoolWithFailover.cpp and Cluster.cpp but it seems that my changes ain't work out...
I will be really appreciate it if you can provide me with some direction on which part of code should I be focusing on!

Logs show segmentation fault at startup: https://s3.amazonaws.com/clickhouse-test-reports/66791/32e22049ce4967a220ae832a9d0cba889a3522e6/fast_test/server.log which is a null pointer dereference (for reading).

Hi @alexey-milovidov,
I've been working on fixing the issues related to connection timeouts and keep-alive settings in, I tried to rewrite my implemenation to fix the bug, but I encountered some error that really stuck me for a few days. It would be really helpful if you could kindly in reviewing my changes.

Here’s a quick summary of what I’ve done:

1. ConnectionPoolWithFailover.cpp:
   Function Modified: ConnectionPoolWithFailover::get
   What I Did: I updated the lambda function inside the get method to properly set socket timeouts and enable keep-alive on the connections. The lambda now returns a TryResult that fits the expected TryGetEntryFunc type.

2. Cluster.cpp:
   Adjustments: I tweaked the for-loop that iterates over shards_info to make sure it correctly gets connections and sets their socket timeouts and keep-alive settings.

3. ConnectionTimeouts.h:
   Changes: I added a constructor to the ConnectionTimeouts struct so it can take multiple Poco::Timespan parameters. This helps with initializing the timeouts properly.
   These changes should ensure the connections have the right timeouts and keep-alive settings, and the lambda function now matches the expected type.

Despite refactoring my code based on the log you shared with me, I still encounter the following error:
Code: 210. DB::NetException: Connection refused (localhost:9000). (NETWORK_ERROR)

I wasn't sure if I am changing the correct file, or did I over complicate the task...

It would be incredibly helpful if you could provide me with any help or point out any mistakes so I don't go too far down the wrong path.
Thanks a lot if you could do me a favor, I will be really appreciate that

update: Some new changes were implemented and it seems to work well, I will apply testing on it

Hi @alexey-milovidov @devcrafter! Thanks for taking care of this PR,
I tried to rebase the current PR but it has the previous base with flaky tests issue that cannot be passed...

I just create a new rebased PR from with the same changes Ive made from this one, could you please check that one (#68581) instead? Appreciate it!!

Hi @alexey-milovidov @devcrafter! Thanks for taking care of this PR, I tried to rebase the current PR but it has the previous base with flaky tests issue that cannot be passed...

I just create a new rebased PR from with the same changes Ive made from this one, could you please check that one (#68581) instead? Appreciate it!!

There is no need to create new PR.
You've just messed up things with 02572_query_views_log_background_thread. Also, if you add new settings, it's necessary to add it to settings changes history.

@devcrafter Thank you for taking care of this issue, I will fix the code based on the comments, thank you!!

Dear @devcrafter, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.