Skip to content

Fix flakiness of async insert tests due to adaptive timeout#66771

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Algunenano:async_flaky
Jul 19, 2024
Merged

Fix flakiness of async insert tests due to adaptive timeout#66771
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Algunenano:async_flaky

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Jul 19, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix flakiness of async insert tests due to adaptive timeout

The problem is that when adaptive timeouts are active (by default) the first insert might be immediate if the queue had been used before and has been unused for more than async_insert_busy_timeout_max_ms (which is possible). Disabling adaptive timeouts disables this immediate push.

Closes #47866 (we can open different tickets for other issues, as most of the reports are now old or incorrect)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 19, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jul 19, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit e91c4b2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nikitamikhaylov nikitamikhaylov self-assigned this Jul 19, 2024
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 19, 2024
Merged
19 tasks
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 19, 2024

It's strange to see "tests are not finished". I see no fatal errors in the log, and no failed tests.
I checked the script, process_functions_tests_result.py, and it happens when there is no All tests have finished message in the log. There is, indeed, no such message. Let's check further...

@alexey-milovidov alexey-milovidov mentioned this pull request Jul 19, 2024
Merged
18 tasks
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 19, 2024 •
edited
Loading

The message is also explicitly deleted in case of timeout:
docker/test/stateless/run.sh:
#66790

Upd: no, it is something different.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 19, 2024

Exit code 143 means signal 15, "terminate".

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 19, 2024

Funny, but we have yet another timeout inside a function:

timeout -k 60m -s TERM --preserve-status 140m  clickhouse-test --testname --shard --zookeeper --check-zookeeper-session --hung-check --print-time \
         --no-drop-if-fail --test-runs "$NUM_TRIES" "${ADDITIONAL_OPTIONS[@]}" 2>&1 \
    | ts '%Y-%m-%d %H:%M:%S' \
    | tee -a test_output/test_result.txt

Which sends terminate.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 19, 2024

Almost surely, it is #66783

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jul 19, 2024
Merged via the queue into ClickHouse:master with commit 54b1bcf Jul 19, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 19, 2024
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 20, 2024
Merged
18 tasks
@CheSema CheSema mentioned this pull request Jul 23, 2024
Merged
19 tasks
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 28, 2024

@Algunenano Not fixed: #67298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Functional tests for async inserts are flaky

6 participants

@Algunenano @robot-ch-test-poll4 @alexey-milovidov @nikitamikhaylov @robot-clickhouse @robot-clickhouse-ci-2