Skip to content

Fix 01246_buffer_flush flakiness#66188

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/01246_buffer_flush-v10
Jul 7, 2024
Merged

Fix 01246_buffer_flush flakiness#66188
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/01246_buffer_flush-v10

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 7, 2024

  • reduce min_time for Buffer's min test
  • rewrite the test to .sh to avoid extra sleeping time (with .sql we have to wait the max time)
  • change the assertion for min test, the time there should not exceed max time (100 seconds), this should fix with test flakiness 1 even after 2.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@azat
Fix 01246_buffer_flush flakiness
5aedbac 
- reduce min_time for Buffer's min test
- rewrite the test to .sh to avoid extra sleeping time (with .sql we
  have to wait the max time)
- change the assertion for min test, the time there should not exceed
  max time (100 seconds), this should fix with test flakiness [1] even
  after [2].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/76119a4567ce2ac9c0aff715c1a9ba2607e806e0/stateless_tests__tsan__[3_5].html
  [2]: ClickHouse#65310

Signed-off-by: Azat Khuzhin <[email protected]>
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 7, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jul 7, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 5aedbac with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this Jul 7, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jul 7, 2024
Merged via the queue into ClickHouse:master with commit 0669270 Jul 7, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 7, 2024
@azat azat deleted the tests/01246_buffer_flush-v10 branch July 8, 2024 05:57
@rschu1ze rschu1ze mentioned this pull request Jul 24, 2024
Merged
@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Jul 24, 2024

@azat There was unfortunately another failure here ... https://s3.amazonaws.com/clickhouse-test-reports/66934/919005c4f70b044ecd9cc1bbce5dc5e276e11929/stateless_tests__tsan__s3_storage__[4_4].html

@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 25, 2024

@rschu1ze should be fixed by #67099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@azat @robot-ch-test-poll4 @rschu1ze @alexey-milovidov @robot-clickhouse @robot-ch-test-poll1