Skip to content

Add a test for #58998#66101

Merged
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:add-test-for-58998
Jul 8, 2024
Merged

Add a test for #58998#66101
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:add-test-for-58998

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Jul 4, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Resolves #58998.

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 4, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Jul 4, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 204f2e1 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@alexey-milovidov alexey-milovidov self-assigned this Jul 4, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 7, 2024

@CurtizJ tests have failed.

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jul 8, 2024

But the added test hasn't failed... Of course we can rerun tests.

@CurtizJ CurtizJ added this pull request to the merge queue Jul 8, 2024
Merged via the queue into ClickHouse:master with commit fca47bb Jul 8, 2024
@CurtizJ CurtizJ deleted the add-test-for-58998 branch July 8, 2024 23:15
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

5 participants

@CurtizJ @robot-clickhouse @alexey-milovidov @robot-ch-test-poll1 @robot-ch-test-poll3