Tests: Fix timeouts handling in case of github timeout termination and clickhouse-test hang when server die by fm4v · Pull Request #66036 · ClickHouse/ClickHouse

fm4v · 2024-07-03T11:50:11Z

Add timeouts that are slightly shorter than github's timeouts to stop clickhouse-test before github's limits are reached.
In cases where clickhouse-server dies, clickhouse-test can sometimes hang indefinitely. Fix this by removing the queue in clickhouse-tests.

Closes: #66000
Fixes empty reports:
https://s3.amazonaws.com/clickhouse-test-reports/65984/b25a58cd85a7e3c22154b9e054c4f454d0b92b53/fast_test.html
https://s3.amazonaws.com/clickhouse-test-reports/65979/4f66a6651afc9f655c820fedf6a6163fc4942fe9/fast_test.html

Changelog category (leave one):

Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix problem when github terminate instances by timeout and artifacts are not collected and full test report is not generated.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

Allow: All Required Checks
Allow: Stateless tests
Allow: Stateful tests
Allow: Integration Tests
Allow: Performance tests
Allow: All Builds
Allow: batch 1, 2 for multi-batch jobs
Allow: batch 3, 4, 5, 6 for multi-batch jobs

Exclude: Style check
Exclude: Fast test
Exclude: All with ASAN
Exclude: All with TSAN, MSAN, UBSAN, Coverage
Exclude: All with aarch64, release, debug

…from hanging when a server dies

robot-clickhouse-ci-1 · 2024-07-03T11:51:26Z

This is an automated comment for commit be8945f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

azat

I like the idea of simplify clickhouse-test!

tests/clickhouse-test

docker/test/stateless/run.sh

azat · 2024-07-03T16:40:58Z

tests/clickhouse-test

-    raise Terminated(f"Terminated with {sig} signal")
-
-
 def stop_tests():


Also, maybe we should call it from signal handler? Or it will be handled gracefully and called from other parts of the code?

azat · 2024-07-03T16:42:52Z

While you are here, maybe you can add a global except KeyboardInterrupt, so that you will not see useless python's traceback on SIGINT, and instead, SIGINT should wait all running tests, but do not start anything new. Subsequent SIGINT should terminate it without waiting for current tests (but killing them)

But maybe it worth to do in a separate PR

…eports

azat · 2024-07-14T05:55:05Z

docker/test/stateless/run.sh

 fi

-timeout_with_logging "$MAX_RUN_TIME" bash -c run_tests ||:
+timeout_with_logging "$TIMEOUT" bash -c run_tests ||:


I don't see that this helps here - https://s3.amazonaws.com/clickhouse-test-reports/66311/076d2bb960a797c6fb25fcf0d3e390b3d695de46/stateless_tests__debug__[2_2].html

Can you please take a look why?

Please rebase, timeout is decreased and works

Where? I don't see any $TIMEOUT adjustments apart from this PR

How about this one https://s3.amazonaws.com/clickhouse-test-reports/66439/669ce7cd40881a075fe473027e6668d13683c840/stateful_tests__tsan_.html?

There is no change for stateful tests because they use stateful/run.sh, which has a larger timeout. I will fix that as well.

fm4v added 2 commits July 3, 2024 13:37

Tests: fix timeouts handling in case of github timeout termination

fe43ea2

Tests: Eliminating the global tests queue to prevent clickhouse-test …

b88be72

…from hanging when a server dies

robot-clickhouse-ci-2 added the pr-build Pull request with build/testing/packaging improvement label Jul 3, 2024

fm4v added the can be tested Allows running workflows for external contributors label Jul 3, 2024

azat reviewed Jul 3, 2024

View reviewed changes

tests/clickhouse-test Show resolved Hide resolved

docker/test/stateless/run.sh Outdated Show resolved Hide resolved

Review fixes

af84523

azat reviewed Jul 3, 2024

View reviewed changes

fm4v added 3 commits July 3, 2024 19:39

Review fixes 2

a19eb86

Fix fasttest

c4005d7

Merge remote-tracking branch 'origin/master' into fix-missing-tests-r…

be8945f

…eports

fm4v added this pull request to the merge queue Jul 7, 2024

Merged via the queue into master with commit 6d15bff Jul 7, 2024

fm4v deleted the fix-missing-tests-reports branch July 7, 2024 18:37

robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 7, 2024

kssenii mentioned this pull request Jul 11, 2024

Update run.sh #66290

Merged

19 tasks

azat reviewed Jul 14, 2024

View reviewed changes

This was referenced Jul 14, 2024

Fix possible data-race StorageKafka with statistics_interval_ms>0 #66311

Merged

[RFC] Fix jemalloc assertion due to non-monotonic CLOCK_MONOTONIC_COARSE #66439

Merged

fm4v self-assigned this Dec 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests: Fix timeouts handling in case of github timeout termination and clickhouse-test hang when server die#66036

Tests: Fix timeouts handling in case of github timeout termination and clickhouse-test hang when server die#66036
fm4v merged 6 commits intomasterfrom
fix-missing-tests-reports

fm4v commented Jul 3, 2024 •

edited

Loading

Uh oh!

robot-clickhouse-ci-1 commented Jul 3, 2024 •

edited by robot-ch-test-poll1

Loading

Uh oh!

azat left a comment

Uh oh!

Uh oh!

Uh oh!

azat Jul 3, 2024

Uh oh!

azat commented Jul 3, 2024

Uh oh!

azat Jul 14, 2024

Uh oh!

fm4v Jul 14, 2024

Uh oh!

azat Jul 14, 2024

Uh oh!

fm4v Jul 14, 2024

Uh oh!

azat Jul 14, 2024

Uh oh!

fm4v Jul 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		raise Terminated(f"Terminated with {sig} signal")


		def stop_tests():

Conversation

fm4v commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

CI Settings (Only check the boxes if you know what you are doing):

Uh oh!

robot-clickhouse-ci-1 commented Jul 3, 2024 • edited by robot-ch-test-poll1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

azat Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

azat commented Jul 3, 2024

Uh oh!

azat Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

fm4v Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

azat Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

fm4v Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

azat Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

fm4v Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fm4v commented Jul 3, 2024 •

edited

Loading

robot-clickhouse-ci-1 commented Jul 3, 2024 •

edited by robot-ch-test-poll1

Loading