Skip to content

Prevent 03172_error_log_table_not_empty from running in parallel#65725

Closed
pamarcos wants to merge 1 commit intoClickHouse:masterfrom
pamarcos:03172-error-log-table-not-empty-no-parallel
Closed

Prevent 03172_error_log_table_not_empty from running in parallel#65725
pamarcos wants to merge 1 commit intoClickHouse:masterfrom
pamarcos:03172-error-log-table-not-empty-no-parallel

Conversation

@pamarcos
Copy link
Copy Markdown
Member

@pamarcos pamarcos commented Jun 26, 2024 •
edited
Loading

Prevent 03172_error_log_table_not_empty from running in parallel

As per this comment, we'd rather prevent this test from running in parallel. As it was before this change we didn't have false negatives, but we may have false positives if another parallel test throws errors 111, 222 or 333.

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

@pamarcos pamarcos requested a review from devcrafter June 26, 2024 13:49
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jun 26, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit e23a250 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Cloud fork sync (only for ClickHouse Inc. employees)If it fails, ask a maintainer for help✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckChecks correctness of the PR's body✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@pamarcos pamarcos mentioned this pull request Jun 26, 2024
Merged
@pamarcos
Copy link
Copy Markdown
Member Author

pamarcos commented Jul 1, 2024

I'm closing this one since after @Algunenano's message there's been no other comment to support why not running this in parallel was a better idea. Seems the cost of running those tests sequentially is quite hard, so we'd rather not add new ones unless it's completely necessary.

@pamarcos pamarcos closed this Jul 1, 2024
@pamarcos pamarcos deleted the 03172-error-log-table-not-empty-no-parallel branch July 1, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

@devcrafter devcrafter Awaiting requested review from devcrafter

Assignees

No one assigned

Labels

pr-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pamarcos @robot-ch-test-poll1 @Algunenano