You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for prewhere in parquet native reader (StorageFile is supported)
Documentation entry for user-facing changes
When reading a Parquet file, if the prewhere_info is provided, the Parquet native reader should:
Read the columns with the prewhere predicate (active columns) .
Filter the result and get the filter mask.
Read the remaining columns (lazy columns) and filter the page using the filter mask. If no row is selected in the page, it should skip the page.
Build the final result chunk
A performance benchmark will be added here later.
TODO:
Currently, only explicit use of PREWHERE in SQL is supported. Automatic moving of some predicates to prewhere clause based on column sizes should be supported. This can reuse the logic from the merge tree i guess.
Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table
Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process
Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here
Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc
Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts
Dear @CurtizJ, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.
Dear @divanik, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can be testedAllows running workflows for external contributorspr-featurePull request with new product feature
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for prewhere in parquet native reader (StorageFile is supported)
Documentation entry for user-facing changes
When reading a Parquet file, if the prewhere_info is provided, the Parquet native reader should:
A performance benchmark will be added here later.
TODO:
Currently, only explicit use of PREWHERE in SQL is supported. Automatic moving of some predicates to prewhere clause based on column sizes should be supported. This can reuse the logic from the merge tree i guess.
Support other storage engines
CI Settings (Only check the boxes if you know what you are doing):