Skip to content

[Feature] Add support for prewhere in parquet native reader#65527

Closed
Clark0 wants to merge 2 commits intoClickHouse:masterfrom
Clark0:support-parquet-native-prewhere
Closed

[Feature] Add support for prewhere in parquet native reader#65527
Clark0 wants to merge 2 commits intoClickHouse:masterfrom
Clark0:support-parquet-native-prewhere

Conversation

@Clark0
Copy link
Copy Markdown
Contributor

@Clark0 Clark0 commented Jun 21, 2024

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add support for prewhere in parquet native reader (StorageFile is supported)

Documentation entry for user-facing changes

When reading a Parquet file, if the prewhere_info is provided, the Parquet native reader should:

  1. Read the columns with the prewhere predicate (active columns) .
  2. Filter the result and get the filter mask.
  3. Read the remaining columns (lazy columns) and filter the page using the filter mask. If no row is selected in the page, it should skip the page.
  4. Build the final result chunk

A performance benchmark will be added here later.

TODO:

  • Currently, only explicit use of PREWHERE in SQL is supported. Automatic moving of some predicates to prewhere clause based on column sizes should be supported. This can reuse the logic from the merge tree i guess.

  • Support other storage engines

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@nikitamikhaylov nikitamikhaylov added the can be tested Allows running workflows for external contributors label Jun 21, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-feature Pull request with new product feature label Jun 21, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jun 21, 2024

This is an automated comment for commit a5485f1 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Cloud fork sync (only for ClickHouse Inc. employees)If it fails, ask a maintainer for help❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
PR CheckChecks correctness of the PR's body❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CurtizJ CurtizJ self-assigned this Nov 7, 2024
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 10, 2024

Dear @CurtizJ, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@alexey-milovidov alexey-milovidov mentioned this pull request Dec 31, 2024
76 tasks
@divanik
Copy link
Copy Markdown
Member

divanik commented Jan 17, 2025

@Clark0, I am eager to review your pull request. Could you please merge master and add tests?

@Clark0
Copy link
Copy Markdown
Contributor Author

Clark0 commented Jan 18, 2025

@Clark0, I am eager to review your pull request. Could you please merge master and add tests?

Thanks, let me rebase onto master and add some tests recently

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 18, 2025

Dear @divanik, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@ucasfl
Copy link
Copy Markdown
Collaborator

ucasfl commented May 6, 2025

May I ask is there any update on this feature?

@alexey-milovidov
Copy link
Copy Markdown
Member

Superseded by #82789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants