Update to libunwind 8.1.7 by al13n321 · Pull Request #65509 · ClickHouse/ClickHouse

al13n321 · 2024-06-20T22:06:59Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

In hopes that it'll fix some bugs that cause segfaults, although AFAICT fixes neither of the bugs in ClickHouse/libunwind#27

robot-clickhouse-ci-1 · 2024-06-20T22:07:43Z

This is an automated comment for commit 4d88abf with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure

Successful checks

Check name	Description	Status
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

alexey-milovidov · 2024-06-25T01:05:31Z

@al13n321, need to fix the tests.

alexey-milovidov · 2024-07-02T04:32:26Z

Builds have failed.

alexey-milovidov · 2024-07-04T00:46:03Z

@al13n321, it failed.

alexey-milovidov · 2024-07-05T16:34:13Z

@al13n321, jemalloc has failed:

2024-07-05 02:03:10 <jemalloc>: /build/contrib/jemalloc/src/decay.c:92: Failed assertion: "nstime_compare(&decay->epoch, new_time) <= 0"

alexey-milovidov · 2024-07-16T04:05:26Z

@al13n321, it failed entirely and miserably.

Backport #65509 to 24.6: Update to libunwind 8.1.7

…d update) * ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV Fix SIGSEGV due to CPU/Real profiler * ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash Fix crash in libunwind while interpreting debug info * ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7 * ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch Revert libunwind patch * ClickHouse/ClickHouse#66977 from ClickHouse/uwo Apply libunwind fix * ClickHouse/ClickHouse#68312 from ClickHouse/muslwind Apply libunwind changes needed for musl * ClickHouse/ClickHouse#76107 from ClickHouse/owo Apply libunwind fix for DwarfFDECache * ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo Revert "Apply libunwind fix for DwarfFDECache" * ClickHouse/ClickHouse#76178 from ClickHouse/unw Apply libunwind fix for DwarfFDECache, attempt 2 * Update libunwind to aec8e58 * ClickHouse/ClickHouse#67152 from ClickHouse/ohno Uncomment accidentally commented out code in QueryProfiler * ClickHouse/ClickHouse#64058 aarch64 sigaltstack size fix * ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes --------- Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: Michael Kolupaev <[email protected]> Co-authored-by: Antonio Andelic <[email protected]> Co-authored-by: Max Kainov <[email protected]>

…d update) (#11324) * ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV Fix SIGSEGV due to CPU/Real profiler * ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash Fix crash in libunwind while interpreting debug info * ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7 * ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch Revert libunwind patch * ClickHouse/ClickHouse#66977 from ClickHouse/uwo Apply libunwind fix * ClickHouse/ClickHouse#68312 from ClickHouse/muslwind Apply libunwind changes needed for musl * ClickHouse/ClickHouse#76107 from ClickHouse/owo Apply libunwind fix for DwarfFDECache * ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo Revert "Apply libunwind fix for DwarfFDECache" * ClickHouse/ClickHouse#76178 from ClickHouse/unw Apply libunwind fix for DwarfFDECache, attempt 2 * Update libunwind to aec8e58 * ClickHouse/ClickHouse#67152 from ClickHouse/ohno Uncomment accidentally commented out code in QueryProfiler * ClickHouse/ClickHouse#64058 aarch64 sigaltstack size fix * ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes --------- Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: Michael Kolupaev <[email protected]> Co-authored-by: Antonio Andelic <[email protected]> Co-authored-by: Max Kainov <[email protected]>

al13n321 added 2 commits June 20, 2024 22:01

Update libunwind to 18.1.7

8bb6010

Set _LIBUNWIND_REMEMBER_STACK_ALLOC explicitly just in case

424224b

robot-clickhouse-ci-1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jun 20, 2024

alexey-milovidov self-assigned this Jun 20, 2024

alexey-milovidov approved these changes Jun 20, 2024

View reviewed changes

al13n321 added 2 commits June 21, 2024 22:53

There's no Unwind_AppleExtras.cpp anymore

92ff09f

Switch to final commit hash

ad24631

al13n321 added 2 commits June 27, 2024 21:48

Merge remote-tracking branch 'origin/master' into uwu

36f9b41

Apply ClickHouse/libunwind#27 too

840edd9

Merge remote-tracking branch 'origin/master' into uwu

ab4d445

Merge remote-tracking branch 'origin/master' into uwu

b04e6c8

alexey-milovidov added 2 commits July 15, 2024 01:22

Merge branch 'master' into uwu

cae3f63

Merge branch 'master' into uwu

4d88abf

alexey-milovidov added this pull request to the merge queue Jul 17, 2024

Merged via the queue into master with commit b8202e1 Jul 17, 2024

alexey-milovidov deleted the uwu branch July 17, 2024 01:49

robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 17, 2024

antonio2368 mentioned this pull request Jul 22, 2024

Stop ignoring SIGSEGV in GDB #66847

Merged

19 tasks

Algunenano mentioned this pull request Jul 22, 2024

Revert libunwind patch #66850

Merged

19 tasks

antonio2368 added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 20, 2024

robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Sep 20, 2024

robot-clickhouse mentioned this pull request Sep 20, 2024

Cherry pick #65509 to 24.3: Update to libunwind 8.1.7 #69813

Closed

robot-clickhouse mentioned this pull request Sep 20, 2024

Cherry pick #65509 to 24.6: Update to libunwind 8.1.7 #69814

Merged

robot-clickhouse added a commit that referenced this pull request Sep 20, 2024

Backport #65509 to 24.6: Update to libunwind 8.1.7

04c4a09

robot-clickhouse mentioned this pull request Sep 20, 2024

Backport #65509 to 24.6: Update to libunwind 8.1.7 #69815

Merged

robot-ch-test-poll2 added a commit that referenced this pull request Sep 20, 2024

Merge pull request #69815 from ClickHouse/backport/24.6/65509

ba85b41

Backport #65509 to 24.6: Update to libunwind 8.1.7

robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to libunwind 8.1.7#65509

Update to libunwind 8.1.7#65509
alexey-milovidov merged 10 commits intomasterfrom
uwu

al13n321 commented Jun 20, 2024

Uh oh!

robot-clickhouse-ci-1 commented Jun 20, 2024 •

edited by robot-ch-test-poll

Loading

Uh oh!

alexey-milovidov commented Jun 25, 2024

Uh oh!

alexey-milovidov commented Jul 2, 2024

Uh oh!

alexey-milovidov commented Jul 4, 2024

Uh oh!

alexey-milovidov commented Jul 5, 2024

Uh oh!

alexey-milovidov commented Jul 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

al13n321 commented Jun 20, 2024

Changelog category (leave one):

Uh oh!

robot-clickhouse-ci-1 commented Jun 20, 2024 • edited by robot-ch-test-poll Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Jun 25, 2024

Uh oh!

alexey-milovidov commented Jul 2, 2024

Uh oh!

alexey-milovidov commented Jul 4, 2024

Uh oh!

alexey-milovidov commented Jul 5, 2024

Uh oh!

alexey-milovidov commented Jul 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

robot-clickhouse-ci-1 commented Jun 20, 2024 •

edited by robot-ch-test-poll

Loading